Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typed sign message display in dark mode #13479

Merged
merged 7 commits into from
Feb 13, 2025
Merged

fix: typed sign message display in dark mode #13479

merged 7 commits into from
Feb 13, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 13, 2025

Description

Some if the message values for typed sign messages was appearing black in dark mode and thus nor readable.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4191

Manual testing steps

  1. Enable dark mode
  2. Check various signature message content in dark mode

Screenshots/Recordings

Screenshot 2025-02-13 at 7 14 48 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 13, 2025
@jpuri jpuri requested a review from a team as a code owner February 13, 2025 13:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 423578e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8877896f-d825-43fa-8a80-60872ffe3e35

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

matthewwalsh0
matthewwalsh0 previously approved these changes Feb 13, 2025
digiwand
digiwand previously approved these changes Feb 13, 2025
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified w/ iOS simulator

@jpuri jpuri requested a review from a team as a code owner February 13, 2025 14:55
@jpuri jpuri enabled auto-merge February 13, 2025 15:19
@jpuri jpuri added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 51322fd Feb 13, 2025
38 of 39 checks passed
@jpuri jpuri deleted the dark_mode_fix branch February 13, 2025 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants