Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design System]: Updating top margin of wallet creation flow views to be up to DS standards #13491

Closed
9 tasks
vinnyhoward opened this issue Feb 13, 2025 · 0 comments · Fixed by #13501
Closed
9 tasks

[Design System]: Updating top margin of wallet creation flow views to be up to DS standards #13491

vinnyhoward opened this issue Feb 13, 2025 · 0 comments · Fixed by #13501
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0

Comments

@vinnyhoward
Copy link
Contributor

vinnyhoward commented Feb 13, 2025 •
edited
Loading

What is this about?

We recently added top margin to the content of the wallet creation flow but they aren't up to DS standards in this PR

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@vinnyhoward vinnyhoward changed the title [Design]: Updating top margin of wallet creation flow views to be up to DS standards [Design System]: Updating top margin of wallet creation flow views to be up to DS standards Feb 13, 2025
This was referenced Feb 13, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2025
@vinnyhoward
fix(13491): update wallet creation flow styles (#13501)
ed21162 
## **Description**

Follow up fixes for [this
PR](#13463)

## **Related issues**

Fixes:
[#13491](#13491)

## **Manual testing steps**

1. During wallet sign up flow notice that the view is slightly farther
from header
2.
3.

## **Screenshots/Recordings**

NA

### **Before**

NA

### **After**

NA

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 13, 2025
christopherferreira9 pushed a commit that referenced this issue Feb 14, 2025
@vinnyhoward @christopherferreira9
fix(13491): update wallet creation flow styles (#13501)
9137df6 
## **Description**

Follow up fixes for [this
PR](#13463)

## **Related issues**

Fixes:
[#13491](#13491)

## **Manual testing steps**

1. During wallet sign up flow notice that the view is slightly farther
from header
2.
3.

## **Screenshots/Recordings**

NA

### **Before**

NA

### **After**

NA

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(13491): update wallet creation flow styles MetaMask/metamask-mobile
2 participants
@vinnyhoward @metamaskbot