Reduce ambiguity in code writing

[paulincai]

meteor-collection2/package/collection2/main.js

Line 219 in 6b89fa5

Mongo.Collection.prototype[methodName] = function (...args) {

At line 219 and 220 among the parameters "args" is used in both functions and the initialization on line 220 does not use "const" or "let".
It is hard to follow the scope of various variables.

[github-actions]

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

[jankapunkt]

Thank you @paulincai for reporting this. I checked the code and I think this is problematic in multiple ways.

• multiple scopes for same variable names can easily lead to unpredictable code flow
• the args are actually mutated within the functions, which can lead to flaky tests and also unpredictable code flow
• code is much less comprehensible
  I would go with a PR, trying to not be breaking

[StorytellerCZ]

Keeping this open for the next part of working on this as per @jankapunkt