Added opening fault to the Slide Valve component (#356)

* Added opening fault to the Slide Valve component

Signed-off-by: Nabil Youssef <[email protected]>

* Update CHANGELOG.md

* Correction of the slide vale fault so it won't be a breaking change

Signed-off-by: Nabil Youssef <[email protected]>

* Updated CHANGELOG

Signed-off-by: Nabil Youssef <[email protected]>

* Changed fault parameter in slide valve

Signed-off-by: Nabil Youssef <[email protected]>

* Deleted useless info in the control valve component

Signed-off-by: Nabil Youssef <[email protected]>

Signed-off-by: Nabil Youssef <[email protected]>

Author: nabily-met

CHANGELOG.md

@@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 [PR#355](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/355) added `PressureCut` and `Leak` components for the flue gases medium.
 
+[PR#356](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/356) Added an  `opening_fault` in the `SlideValve` component to model slight decrease in the valve opening.
+
 ### Changed
 
 ### Fixed

MetroscopeModelingLibrary/Examples/CCGT/MetroscopiaCCGT/MetroscopiaCCGT_faulty.mo

@@ -7,26 +7,30 @@ model MetroscopiaCCGT_faulty "Metroscopia CCGT faulty"
     HPsuperheater2(faulty=true),
     Reheater(faulty=true),
     evaporator(faulty=true),
-    economiser(faulty=true));
+    economiser(faulty=true),
+    HPST_control_valve(faulty=true));
 
-//Heat exchangers failures
-  input Real Reheater_fouling(start=0);
-  input Real evaporator_fouling(start=0);
-  input Real HPsuperheater1_fouling(start=0);
-  input Real HPsuperheater2_fouling(start=0);
-  input Real economiser_fouling(start=0);
-  input Real condenser_fouling(start=0);
-  input Real condenser_air_intake(start=0);
+  // Heat exchangers failures
+  input Real Failure_Reheater_fouling(start=0);
+  input Real Failure_evaporator_fouling(start=0);
+  input Real Failure_HPsuperheater1_fouling(start=0);
+  input Real Failure_HPsuperheater2_fouling(start=0);
+  input Real Failure_economiser_fouling(start=0);
+  input Real Failure_condenser_fouling(start=0);
+  input Real Failure_condenser_air_intake(start=0);
 
-//Leaks
-  input Real bypass_HP_turbine_to_condenser_leak_Q(start=0);
-  input Real bypass_HP_CV_to_condenser_leak_Q(start=0);
-  input Real bypass_IP_turbine_to_condenser_leak_Q(start=0);
-  input Real bypass_IP_CV_to_condenser_leak_Q(start=0);
-  input Real deSH_controlValve_leak_Q(start=0);
+  // Leaks
+  input Real Failure_bypass_HP_turbine_to_condenser_leak_Q(start=0);
+  input Real Failure_bypass_HP_CV_to_condenser_leak_Q(start=0);
+  input Real Failure_bypass_IP_turbine_to_condenser_leak_Q(start=0);
+  input Real Failure_bypass_IP_CV_to_condenser_leak_Q(start=0);
+  input Real Failure_deSH_controlValve_leak_Q(start=0);
 
-//Gas turbine failures
-  input Real AirFilter_fouling;
+  // Gas turbine failures
+  input Real Failure_AirFilter_fouling;
+
+  // Steam turbine
+  input Real Failure_HPST_CV_closed_valve(start=0);
 
   MetroscopeModelingLibrary.WaterSteam.Pipes.Leak bypass_HP_turbine_to_condenser_leak
     annotation (Placement(transformation(
@@ -56,28 +60,29 @@ model MetroscopiaCCGT_faulty "Metroscopia CCGT faulty"
 equation
 
   //Condenser
-  condenser.fouling=condenser_fouling;
-  condenser.air_intake=condenser_air_intake;
+  condenser.fouling = Failure_condenser_fouling;
+  condenser.air_intake = Failure_condenser_air_intake;
 
   //Reheater
-  Reheater.fouling=Reheater_fouling;
-  evaporator.fouling=evaporator_fouling;
+  Reheater.fouling = Failure_Reheater_fouling;
+  evaporator.fouling = Failure_evaporator_fouling;
   //economiser
-  economiser.fouling=economiser_fouling;
+  economiser.fouling = Failure_economiser_fouling;
 
   //Superheater
-  HPsuperheater1.fouling=HPsuperheater1_fouling;
-  HPsuperheater2.fouling=HPsuperheater2_fouling;
-  deSH_controlValve_leak.Q = deSH_controlValve_leak_Q + 1E-3;
+  HPsuperheater1.fouling = Failure_HPsuperheater1_fouling;
+  HPsuperheater2.fouling = Failure_HPsuperheater2_fouling;
+  deSH_controlValve_leak.Q = Failure_deSH_controlValve_leak_Q + 1E-3;
 
   //Steam Turbines
-  bypass_HP_turbine_to_condenser_leak.Q=bypass_HP_turbine_to_condenser_leak_Q+1E-3;
-  bypass_HP_CV_to_condenser_leak.Q=bypass_HP_CV_to_condenser_leak_Q+1E-3;
-  bypass_IP_turbine_to_condenser_leak.Q=bypass_IP_turbine_to_condenser_leak_Q+1E-3;
-  bypass_IP_CV_to_condenser_leak.Q=bypass_IP_CV_to_condenser_leak_Q+1E-3;
+  bypass_HP_turbine_to_condenser_leak.Q = Failure_bypass_HP_turbine_to_condenser_leak_Q+1E-3;
+  bypass_HP_CV_to_condenser_leak.Q = Failure_bypass_HP_CV_to_condenser_leak_Q+1E-3;
+  bypass_IP_turbine_to_condenser_leak.Q = Failure_bypass_IP_turbine_to_condenser_leak_Q+1E-3;
+  bypass_IP_CV_to_condenser_leak.Q = Failure_bypass_IP_CV_to_condenser_leak_Q+1E-3;
+  HPST_control_valve.closed_valve = Failure_HPST_CV_closed_valve;
 
   //Gas turbine
-  AirFilter.fouling=AirFilter_fouling;
+  AirFilter.fouling = Failure_AirFilter_fouling;
 
   connect(P_HPST_in_sensor.C_in, HPST_control_valve.C_out) annotation (Line(
         points={{-180,148},{-183.375,148},{-183.375,148},{-186.75,148}}, color={

MetroscopeModelingLibrary/Partial/Pipes/ControlValve.mo

@@ -5,7 +5,7 @@ partial model ControlValve
   import MetroscopeModelingLibrary.Units.Inputs;
   import MetroscopeModelingLibrary.Constants;
 
-  Inputs.InputCv Cvmax(start=1e4) "Maximum CV (active if mode_caract=0)";
+  Inputs.InputCv Cvmax(start=1e4) "Maximum CV";
   Units.Cv Cv(start=1e4) "Cv";
   Modelica.Blocks.Interfaces.RealInput Opening(unit="1", min=0., max=1., nominal=0.5) annotation (Placement(
         transformation(extent={{-20,-20},{20,20}},

MetroscopeModelingLibrary/Partial/Pipes/SlideValve.mo

@@ -7,9 +7,18 @@ partial model SlideValve
 
   Inputs.InputCv Cv(start=1e4) "Cv of the valve";
 
+  parameter Boolean faulty = false;
+  Real closed_valve; // Valve not fully opened
+
 equation
+    // Failure modes
+  if not faulty then
+    closed_valve = 0;
+  end if;
+
   /* Pressure loss */
-  DP*Cv*abs(Cv) = -1.733e12*Q^2/rho^2;
+  DP*(1 - closed_valve)^2*Cv*abs(Cv) = -1.733e12*Q^2/rho^2;
+
 
   annotation (
     Icon(coordinateSystem(

MetroscopeModelingLibrary/Tests/WaterSteam/Pipes/SlideValve_direct.mo

@@ -23,7 +23,7 @@ model SlideValve_direct
         rotation=0,
         origin={58,-6.10623e-16})));
 
-  MetroscopeModelingLibrary.WaterSteam.Pipes.SlideValve    control_valve annotation (Placement(transformation(extent={{-16.5,-5.93938},{16.5,26.7272}})));
+  MetroscopeModelingLibrary.WaterSteam.Pipes.SlideValve slide_valve annotation (Placement(transformation(extent={{-16.5,-5.93938},{16.5,26.7272}})));
 
 equation
   // Boundary conditions
@@ -32,8 +32,8 @@ equation
   source.Q_out = source_Q;
 
   // Calibrated Parameters
-  control_valve.Cv = Cv;
+  slide_valve.Cv = Cv;
 
-  connect(control_valve.C_in, source.C_out) annotation (Line(points={{-16.5,-1.81818e-06},{-34.75,-1.81818e-06},{-34.75,0},{-53,0}},color={28,108,200}));
-  connect(control_valve.C_out, sink.C_in) annotation (Line(points={{16.5,-1.81818e-06},{34.75,-1.81818e-06},{34.75,0},{53,0}}, color={28,108,200}));
+  connect(slide_valve.C_in, source.C_out) annotation (Line(points={{-16.5,-1.81818e-06},{-34.75,-1.81818e-06},{-34.75,0},{-53,0}}, color={28,108,200}));
+  connect(slide_valve.C_out, sink.C_in) annotation (Line(points={{16.5,-1.81818e-06},{34.75,-1.81818e-06},{34.75,0},{53,0}}, color={28,108,200}));
 end SlideValve_direct;

MetroscopeModelingLibrary/Tests/WaterSteam/Pipes/SlideValve_reverse.mo

@@ -17,7 +17,7 @@ model SlideValve_reverse
   input Units.Pressure outlet_pressure(start=9e5) "Pa";
 
   // Calibrated parameter
-  output Units.Cv Cv "Cvmax";
+  output Units.Cv Cv "Cv";
 
   // Components
   .MetroscopeModelingLibrary.WaterSteam.BoundaryConditions.Source source annotation (Placement(transformation(extent={{-68,-9.99996},{-48,9.99996}})));
@@ -26,7 +26,7 @@ model SlideValve_reverse
         rotation=0,
         origin={58,-6.10623e-16})));
 
-  MetroscopeModelingLibrary.WaterSteam.Pipes.SlideValve    control_valve annotation (Placement(transformation(extent={{-16.5,-5.93938},{16.5,26.7272}})));
+  MetroscopeModelingLibrary.WaterSteam.Pipes.SlideValve slide_valve annotation (Placement(transformation(extent={{-16.5,-5.93938},{16.5,26.7272}})));
 
   MetroscopeModelingLibrary.Sensors.WaterSteam.PressureSensor outlet_pressure_sensor annotation (Placement(transformation(extent={{26,-10},{46,10}})));
 equation
@@ -39,9 +39,9 @@ equation
   outlet_pressure_sensor.P = outlet_pressure;
 
   // Calibrated Parameters
-  control_valve.Cv = Cv;
+  slide_valve.Cv = Cv;
 
-  connect(control_valve.C_in, source.C_out) annotation (Line(points={{-16.5,-1.81818e-06},{-34.75,-1.81818e-06},{-34.75,0},{-53,0}},color={28,108,200}));
-  connect(control_valve.C_out, outlet_pressure_sensor.C_in) annotation (Line(points={{16.5,-1.81818e-06},{22,-1.81818e-06},{22,0},{26,0}}, color={28,108,200}));
+  connect(slide_valve.C_in, source.C_out) annotation (Line(points={{-16.5,-1.81818e-06},{-34.75,-1.81818e-06},{-34.75,0},{-53,0}}, color={28,108,200}));
+  connect(slide_valve.C_out, outlet_pressure_sensor.C_in) annotation (Line(points={{16.5,-1.81818e-06},{22,-1.81818e-06},{22,0},{26,0}}, color={28,108,200}));
   connect(sink.C_in, outlet_pressure_sensor.C_out) annotation (Line(points={{53,0},{46,0}}, color={28,108,200}));
 end SlideValve_reverse;