Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch apt proxy implementation #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ncstate-mafields
Copy link

This PR updates the implementation of the proxy configuration by using the apt::settings defined resource type instead of passing the configuration value through the apt class resource.

This allows previous inclusions of the apt class without a duplicate resource error, and achieves the same end result, including executing the apt_update exec afterwards. By checking for a previous definition of apt::setting used by the main apt class when configuring a proxy setting there, we can avoid duplicate resource errors as well.

The metadata has also been updated to include puppetlabs/apt version 9.x, since 9.0.2 is currently released and in testing works well with this module.

All existing unit tests pass successfully, and a functional test switching between the old implementation and the new revealed no effective changes in the catalog.

Alternate implementation of #11
Fixes #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate declaration: Class[Apt] is already declared
1 participant