Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation of the proxy configuration by using the
apt::settings
defined resource type instead of passing the configuration value through theapt
class resource.This allows previous inclusions of the
apt
class without a duplicate resource error, and achieves the same end result, including executing theapt_update
exec afterwards. By checking for a previous definition ofapt::setting
used by the mainapt
class when configuring a proxy setting there, we can avoid duplicate resource errors as well.The metadata has also been updated to include puppetlabs/apt version 9.x, since 9.0.2 is currently released and in testing works well with this module.
All existing unit tests pass successfully, and a functional test switching between the old implementation and the new revealed no effective changes in the catalog.
Alternate implementation of #11
Fixes #12