Drop LLVM < 9 support (#123)

Author: Micha Reiser

llvm-node.d.ts

@@ -105,7 +105,7 @@ declare namespace llvm {
     Acquire,
     Release,
     AcquireRelease,
-    SequentiallyConsistent
+    SequentiallyConsistent,
   }
 
   class Value {
@@ -337,10 +337,6 @@ declare namespace llvm {
     SPIR_KERNEL,
     Intel_OCL_BI,
     X86_64_SysV,
-    /**
-     * @deprecated use Win64 instead
-     */
-    X86_64_Win64,
     Win64,
     X86_VectorCall,
     HHVM,
@@ -698,7 +694,7 @@ declare namespace llvm {
       Max,
       Min,
       UMax,
-      UMin
+      UMin,
     }
   }
 

src/bitcode/bitcode-writer.cc

@@ -28,11 +28,7 @@ NAN_METHOD(WriteBitcodeToFile) {
         return Nan::ThrowError((messagePrefix + errorCode.message()).c_str());
     }
 
-#if LLVM_VERSION_MAJOR > 6
     llvm::WriteBitcodeToFile(*module, byteCodeFile);
-#else
-    llvm::WriteBitcodeToFile(module, byteCodeFile);
-#endif
 
     byteCodeFile.flush();
     byteCodeFile.close();

src/ir/argument.cc

@@ -65,11 +65,7 @@ NAN_METHOD(ArgumentWrapper::New) {
         argNo = Nan::To<uint32_t>(info[3]).FromJust();
     }
 
-#if LLVM_VERSION_MAJOR == 4
-    auto* argument = new llvm::Argument { type, name, function };
-#else
     auto* argument = new llvm::Argument { type, name, function, argNo };
-#endif
     auto* wrapper = new ArgumentWrapper { argument };
     wrapper->Wrap(info.This());
 
@@ -126,12 +122,7 @@ NAN_METHOD(ArgumentWrapper::addDereferenceableAttr) {
     llvm::AttrBuilder builder {};
     builder.addDereferenceableAttr(bytes);
 
-#if LLVM_VERSION_MAJOR == 4
-    auto attributes = llvm::AttributeSet::get(argument->getContext(), argument->getArgNo() + 1, builder);
-    argument->addAttr(attributes);
-#else
     argument->addAttrs(builder);
-#endif
 }
 
 llvm::Argument *ArgumentWrapper::getArgument() {

src/ir/call-inst.cc

@@ -78,11 +78,7 @@ NAN_METHOD(CallInstWrapper::hasRetAttr) {
     auto kind = static_cast<llvm::Attribute::AttrKind >(Nan::To<uint32_t>(info[0]).FromJust());
     bool hasRetAttr = false;
 
-#if LLVM_VERSION_MAJOR == 4
-    hasRetAttr = call->paramHasAttr(llvm::AttributeSet::ReturnIndex, kind);
-#else
     hasRetAttr = call->hasRetAttr(kind);
-#endif
 
     info.GetReturnValue().Set(hasRetAttr);
 }
@@ -98,11 +94,7 @@ NAN_METHOD(CallInstWrapper::paramHasAttr) {
     const auto kind = static_cast<llvm::Attribute::AttrKind >(Nan::To<uint32_t>(info[1]).FromJust());
     bool paramHasAttr = false;
 
-#if LLVM_VERSION_MAJOR == 4
-    paramHasAttr = call->paramHasAttr(index + 1, kind);
-#else
     paramHasAttr = call->paramHasAttr(index, kind);
-#endif
     info.GetReturnValue().Set(paramHasAttr);
 }
 

src/ir/calling-conv.cc

@@ -34,14 +34,7 @@ NAN_MODULE_INIT(InitCallingConv) {
     Nan::Set(object, Nan::New("SPIR_KERNEL").ToLocalChecked(), Nan::New(llvm::CallingConv::SPIR_KERNEL));
     Nan::Set(object, Nan::New("Intel_OCL_BI").ToLocalChecked(), Nan::New(llvm::CallingConv::Intel_OCL_BI));
     Nan::Set(object, Nan::New("X86_64_SysV").ToLocalChecked(), Nan::New(llvm::CallingConv::X86_64_SysV));
-
-#if LLVM_VERSION_MAJOR == 4
-    Nan::Set(object, Nan::New("X86_64_Win64").ToLocalChecked(), Nan::New(llvm::CallingConv::X86_64_Win64));
-#else
-    Nan::Set(object, Nan::New("X86_64_Win64").ToLocalChecked(), Nan::New(llvm::CallingConv::Win64));
     Nan::Set(object, Nan::New("Win64").ToLocalChecked(), Nan::New(llvm::CallingConv::Win64));
-#endif
-
     Nan::Set(object, Nan::New("X86_VectorCall").ToLocalChecked(), Nan::New(llvm::CallingConv::X86_VectorCall));
     Nan::Set(object, Nan::New("HHVM").ToLocalChecked(), Nan::New(llvm::CallingConv::HHVM));
     Nan::Set(object, Nan::New("HHVM_C").ToLocalChecked(), Nan::New(llvm::CallingConv::HHVM_C));

src/ir/module.cc

@@ -95,15 +95,10 @@ NAN_METHOD(ModuleWrapper::getOrInsertFunction) {
 
     auto functionCallee = Nan::New<v8::Object>();
 
-    #if LLVM_VERSION_MAJOR < 9
-        Nan::Set(functionCallee, Nan::New("callee").ToLocalChecked(), ConstantWrapper::of(module->getOrInsertFunction(name, fnType)));
-        Nan::Set(functionCallee, Nan::New("functionType").ToLocalChecked(), FunctionTypeWrapper::of(fnType));
-    #else
-        auto llvmCallee = module->getOrInsertFunction(name, fnType);
-        Nan::Set(functionCallee, Nan::New("callee").ToLocalChecked(), ValueWrapper::of(llvmCallee.getCallee()));
-        Nan::Set(functionCallee, Nan::New("functionType").ToLocalChecked(), FunctionTypeWrapper::of(llvmCallee.getFunctionType()));
-    #endif
-
+    auto llvmCallee = module->getOrInsertFunction(name, fnType);
+    Nan::Set(functionCallee, Nan::New("callee").ToLocalChecked(), ValueWrapper::of(llvmCallee.getCallee()));
+    Nan::Set(functionCallee, Nan::New("functionType").ToLocalChecked(), FunctionTypeWrapper::of(llvmCallee.getFunctionType()));
+    
     Nan::EscapableHandleScope scope {};
     info.GetReturnValue().Set(scope.Escape(functionCallee));
 }

src/ir/value.cc

@@ -114,11 +114,7 @@ NAN_SETTER(ValueWrapper::setName)
 NAN_METHOD(ValueWrapper::deleteValue)
 {
     auto *wrapper = ValueWrapper::FromValue(info.Holder());
-#if LLVM_VERSION_MAJOR == 4
-    delete wrapper->getValue();
-#else
     wrapper->getValue()->deleteValue();
-#endif
 }
 
 NAN_METHOD(ValueWrapper::replaceAllUsesWith)