Skip to content

Commit cb6e8b7

Browse files
committed
fix: { async: true } -> { async: false } for v5.0 ember-data
- Seems like we want most of the examples to be synchronous - Supports: ember-learn#1988
1 parent fc4db08 commit cb6e8b7

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

guides/v5.0.0/models/customizing-serializers.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ a model:
401401
import Model, { belongsTo } from '@ember-data/model';
402402

403403
export default class CommentModel extends Model {
404-
@belongsTo('post', { async: false, inverse: 'comments' }) originalPost
404+
@belongsTo('post', { async: true, inverse: 'comments' }) originalPost
405405
}
406406
```
407407

@@ -713,8 +713,8 @@ import Model, { attr, hasMany } from '@ember-data/model';
713713
export default class Post extends Model {
714714
@attr('string') title;
715715
@attr('string') tag;
716-
@hasMany('comment', { async: false, inverse: 'post' }) comments;
717-
@hasMany('post', { async: false, inverse: 'relatedPosts' }) relatedPosts;
716+
@hasMany('comment', { async: true, inverse: 'post' }) comments;
717+
@hasMany('post', { async: true, inverse: 'relatedPosts' }) relatedPosts;
718718
}
719719
```
720720

guides/v5.0.0/models/relationships.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ To declare a one-to-one relationship between two models, use
1010
import Model, { belongsTo } from '@ember-data/model';
1111

1212
export default class UserModel extends Model {
13-
@belongsTo('profile', { async: true, inverse: 'user' }) profile;
13+
@belongsTo('profile', { async: false, inverse: 'user' }) profile;
1414
}
1515
```
1616

1717
```javascript {data-filename=app/models/profile.js}
1818
import Model, { belongsTo } from '@ember-data/model';
1919

2020
export default class ProfileModel extends Model {
21-
@belongsTo('user', { async: true, inverse: 'profile' }) user;
21+
@belongsTo('user', { async: false, inverse: 'profile' }) user;
2222
}
2323
```
2424

@@ -31,15 +31,15 @@ To declare a one-to-many relationship between two models, use
3131
import Model, { hasMany } from '@ember-data/model';
3232

3333
export default class BlogPostModel extends Model {
34-
@hasMany('comment', { async: true, inverse: 'blogPost' }) comments;
34+
@hasMany('comment', { async: false, inverse: 'blogPost' }) comments;
3535
}
3636
```
3737

3838
```javascript {data-filename=app/models/comment.js}
3939
import Model, { belongsTo } from '@ember-data/model';
4040

4141
export default class CommentModel extends Model {
42-
@belongsTo('blog-post', { async: true, inverse: 'comments' }) blogPost;
42+
@belongsTo('blog-post', { async: false, inverse: 'comments' }) blogPost;
4343
}
4444
```
4545

@@ -52,15 +52,15 @@ To declare a many-to-many relationship between two models, use
5252
import Model, { hasMany } from '@ember-data/model';
5353

5454
export default class BlogPostModel extends Model {
55-
@hasMany('tag', { async: true, inverse: 'blogPosts' }) tags;
55+
@hasMany('tag', { async: false, inverse: 'blogPosts' }) tags;
5656
}
5757
```
5858

5959
```javascript {data-filename=app/models/tag.js}
6060
import Model, { hasMany } from '@ember-data/model';
6161

6262
export default class TagModel extends Model {
63-
@hasMany('blog-post', { async: true, inverse: 'tags' }) blogPosts;
63+
@hasMany('blog-post', { async: false, inverse: 'tags' }) blogPosts;
6464
}
6565
```
6666

@@ -75,7 +75,7 @@ no inverse relationship exists, specify `{inverse: null }`.
7575
import Model, { belongsTo } from '@ember-data/model';
7676

7777
export default class CommentModel extends Model {
78-
@belongsTo('blog-post', { async: true, inverse: null }) blogPost;
78+
@belongsTo('blog-post', { async: false, inverse: null }) blogPost;
7979
}
8080
```
8181

@@ -97,8 +97,8 @@ Here's an example of a one-to-many reflexive relationship:
9797
import Model, { belongsTo, hasMany } from '@ember-data/model';
9898

9999
export default class FolderModel extends Model {
100-
@hasMany('folder', { async: true, inverse: 'parent' }) children;
101-
@belongsTo('folder', { async: true, inverse: 'children' }) parent;
100+
@hasMany('folder', { async: false, inverse: 'parent' }) children;
101+
@belongsTo('folder', { async: false, inverse: 'children' }) parent;
102102
}
103103
```
104104

@@ -109,7 +109,7 @@ import Model, { attr, belongsTo } from '@ember-data/model';
109109

110110
export default class UserModel extends Model {
111111
@attr('string') name;
112-
@belongsTo('user', { async: true, inverse: 'bestFriend' }) bestFriend;
112+
@belongsTo('user', { async: false, inverse: 'bestFriend' }) bestFriend;
113113
}
114114
```
115115

@@ -119,7 +119,7 @@ You can also define a reflexive relationship that doesn't have an inverse:
119119
import Model, { belongsTo } from '@ember-data/model';
120120

121121
export default class FolderModel extends Model {
122-
@belongsTo('folder', { async: true, inverse: null }) parent;
122+
@belongsTo('folder', { async: false, inverse: null }) parent;
123123
}
124124
```
125125

@@ -141,15 +141,15 @@ First, let's look at the model definitions:
141141
import Model, { hasMany } from '@ember-data/model';
142142

143143
export default class UserModel extends Model {
144-
@hasMany('payment-method', { async: true, inverse: 'user', polymorphic: true }) paymentMethods;
144+
@hasMany('payment-method', { async: false, inverse: 'user', polymorphic: true }) paymentMethods;
145145
}
146146
```
147147

148148
```javascript {data-filename=app/models/payment-method.js}
149149
import Model, { belongsTo } from '@ember-data/model';
150150

151151
export default class PaymentMethodModel extends Model {
152-
@belongsTo('user', { async: true, inverse: 'paymentMethods' }) user;
152+
@belongsTo('user', { async: false, inverse: 'paymentMethods' }) user;
153153
}
154154
```
155155

@@ -262,15 +262,15 @@ Let's assume that we have a `blog-post` and a `comment` model. A single blog pos
262262
import Model, { hasMany } from '@ember-data/model';
263263

264264
export default class BlogPostModel extends Model {
265-
@hasMany('comment', { async: true, inverse: 'blogPost' }) comments;
265+
@hasMany('comment', { async: false, inverse: 'blogPost' }) comments;
266266
}
267267
```
268268

269269
```javascript {data-filename=app/models/comment.js}
270270
import Model, { belongsTo } from '@ember-data/model';
271271

272272
export default class CommentModel extends Model {
273-
@belongsTo('blog-post', { async: true, inverse: 'comments' }) blogPost;
273+
@belongsTo('blog-post', { async: false, inverse: 'comments' }) blogPost;
274274
}
275275
```
276276

0 commit comments

Comments
 (0)