MinecraftCommands
diff --git a/‎bcresources.md
Lines changed: 20 additions & 20 deletions b/‎bcresources.md
Lines changed: 20 additions & 20 deletions
diff --git a/‎debugging.md
Lines changed: 95 additions & 24 deletions b/‎debugging.md
Lines changed: 95 additions & 24 deletions
diff --git a/‎optimising.md
Lines changed: 15 additions & 35 deletions b/‎optimising.md
Lines changed: 15 additions & 35 deletions
diff --git a/‎questions.md
Lines changed: 15 additions & 5 deletions b/‎questions.md
Lines changed: 15 additions & 5 deletions
diff --git a/‎questions/amountitems.md
Lines changed: 2 additions & 2 deletions b/‎questions/amountitems.md
Lines changed: 2 additions & 2 deletions
@@ -12,48 +12,48 @@ Submit a pull request or create a GitHub issue if you've found a useful tool or
 
 ### Utilities
 
-[NBT Editor](http://universalminecrafteditor.com/software/UniversalMC_setup.exe?fdl=1) (Universal Minecraft Editor)
-[NBT Editor](http://www.mcctoolchest.com/Download) (MCC Tool Chest)
+* [NBT Editor](http://universalminecrafteditor.com/software/UniversalMC_setup.exe?fdl=1) (Universal Minecraft Editor)
+* [NBT Editor](http://www.mcctoolchest.com/Download) (MCC Tool Chest)
 
 ### Resources
-[Level format](https://minecraft.wiki/Bedrock_Edition_level_format) (Wiki)
+* [Level format](https://minecraft.wiki/Bedrock_Edition_level_format) (Wiki)
 
 ## World editing
 
 ### Utilities
 
-[MCEdit Unified](http://www.mcedit-unified.net)
-[MCEdit filter collection](http://www.brightmoore.net/mcedit-filters-1) (Adrian Brightmoore) ^[Designed for Java, not all will work in Bedrock]
-[MCEdit filter collection](http://elemanser.com/filters.html) (Texelelf) ^[Designed for Java, not all will work in Bedrock] 
-[MCEdit filter collection specifically for Bedrock](https://github.com/PathwayStudios/Bedrock_MCEdit_Filters/blob/master/CreateShops_README.md) (PathwayStudios)
-[Java to Pocket Edition World converter](https://www.planetminecraft.com/mod/anvil-to-leveldb-converter-java-to-pocket-edition/) (Empire92)
+* [MCEdit Unified](http://www.mcedit-unified.net)
+* [MCEdit filter collection](http://www.brightmoore.net/mcedit-filters-1) (Adrian Brightmoore) ^[Designed for Java, not all will work in Bedrock]
+* [MCEdit filter collection](http://elemanser.com/filters.html) (Texelelf) ^[Designed for Java, not all will work in Bedrock] 
+* [MCEdit filter collection specifically for Bedrock](https://github.com/PathwayStudios/Bedrock_MCEdit_Filters/blob/master/CreateShops_README.md) (PathwayStudios)
+* [Java to Pocket Edition World converter](https://www.planetminecraft.com/mod/anvil-to-leveldb-converter-java-to-pocket-edition/) (Empire92)
 
 ## Resource packs
 
 ### Utilities
 
-[Entity model creator](http://server.zofenia.de/blockbench/) (BlockBench)
-[Entity model creator](https://cubik.studio/) (Cubik) ^[Paid]
+* [Entity model creator](http://server.zofenia.de/blockbench/) (BlockBench)
+* [Entity model creator](https://cubik.studio/) (Cubik) ^[Paid]
 
 ### References
 
-[Creating a resource pack guide](http://minecraft.wiki/Tutorials/Creating_resource_pack_add-ons) (Wiki)
-[Changing entity models guide](http://minecraft.wiki/Tutorials/Changing_Minecraft_entity_models) (Wiki)
-[Sounds list](https://minecraft.wiki/Sounds.json/Bedrock_Edition_values) (Wiki)
+* [Creating a resource pack guide](http://minecraft.wiki/Tutorials/Creating_resource_pack_add-ons) (Wiki)
+* [Changing entity models guide](http://minecraft.wiki/Tutorials/Changing_Minecraft_entity_models) (Wiki)
+* [Sounds list](https://minecraft.wiki/Sounds.json/Bedrock_Edition_values) (Wiki)
 
 # Behavior packs
 
 ### References
 
-[Creating a behavior pack guide](http://minecraft.wiki/Tutorials/Creating_behavior_packs) (Wiki)
-[Entity components for latest release](http://minecraft.wiki/Pocket_Edition_entity_components) (Wiki)
-[Entity components for latest beta](https://minecraft.wiki/Bedrock_Beta_Add-On_Documentation) (Wiki)
-[Loot table guide](http://www.minecraftforum.net/forums/minecraft-pocket-edition/mcpe-maps/mcpe-map-help-requests/2838965-custom-loot-tables-for-pe-win10) (Skylinerw)
-[UI format documentation](https://github.com/bleonard252/mc-uijson/wiki) (bleonard252)
+* [Creating a behavior pack guide](http://minecraft.wiki/Tutorials/Creating_behavior_packs) (Wiki)
+* [Entity components for latest release](http://minecraft.wiki/Pocket_Edition_entity_components) (Wiki)
+* [Entity components for latest beta](https://minecraft.wiki/Bedrock_Beta_Add-On_Documentation) (Wiki)
+* [Loot table guide](http://www.minecraftforum.net/forums/minecraft-pocket-edition/mcpe-maps/mcpe-map-help-requests/2838965-custom-loot-tables-for-pe-win10) (Skylinerw)
+* [UI format documentation](https://github.com/bleonard252/mc-uijson/wiki) (bleonard252)
 
 # Commands
 
 ### References
 
-[Commands list](http://minecraft.wiki/Commands) (Wiki)
-[Data values](https://minecraft.wiki/Bedrock_Edition_data_values) (Wiki)
+* [Commands list](http://minecraft.wiki/Commands) (Wiki)
+* [Data values](https://minecraft.wiki/Bedrock_Edition_data_values) (Wiki)
@@ -6,7 +6,7 @@
 
 For example, if you have a function or chain of command blocks that control an arena, you probably only need those running when someone is actually in the arena.
 
-Consider a "branching" structure of checks. You could start with just `/testfor @a`. If and only if that succeeds you'd run checks to do with players, such as whether a player is holding *any* special item. If a player is holding any special item, run checks to see what kind of special item it is. Only then off of these last checks would you run the commands that make that item work.
+Consider a "branching" structure of checks. You could start with just `/execute if entity @a` (Or `/testfor @a` in pre-1.13). If and only if that succeeds you'd run checks to do with players, such as whether a player is holding *any* special item. If a player is holding any special item, run checks to see what kind of special item it is. Only then off of these last checks would you run the commands that make that item work.
 
 **Don't** achieve this by repeatedly using `/execute` as a condition (e.g: `/execute as @a[tag=holdItem] ...`) while still having all the blocks/commands running, as this will still need to repeatedly evaluate the selector for each command. Instead, you want the commands to not be running at all if the previous check failed.
 
@@ -23,46 +23,26 @@ You can alternatively use the following commands to activate an impulse command
 
 These commands should be conditional blocks on the chain that performs the condition test. Your setup might look [something like this](http://i.imgur.com/vyhnmTH.png).
 
-**Functions** make this even easier and more efficient. You can run a different function only if a selector succeeds/fails, for example:
+**Functions** make this even easier and more efficient. You can run a different function only if a condition (for example, if a specified selector exist) succeeds/fails, for example:
 
     # pre-1.13 syntax
     function code:arena_events if @a[tag=in_arena]
     function code:check_winner unless @a[tag=winner]
     # 1.13+ syntax
     execute if entity @a[tag=in_arena] run function code:arena_events
     execute unless entity @a[tag=winner] run function code:check_winner
+    # 1.13+ syntax (block condition)
+    execute if block 0 60 0 air run function code:missing_block
+    execute unless block 0 90 0 grass_block run function code:place_block
 
-## Slow down your commands
-
-Not everything needs to be running at 20Hz. If you can run some commands at 10Hz instead, you've halved the impact those commands were having. In Bedrock you can just add a delay to a repeating commandblock into the block directly, in Java you need some workaround.
-
-An easy trick with command blocks to make a clock run at half its speed is the following command:
-
-    # pre-1.13 syntax
-    testforblock ~ ~ ~ repeating_command_block * {SuccessCount:0}
-    # 1.13+ syntax
-    execute if block ~ ~ ~ repeating_command_block{SuccessCount:0}
-
-Set up [like this](http://i.imgur.com/OULTCZx.png), the command will alternate between succeeding (as it failed last time so has `SuccessCount:0`) and failing (as it succeeded last time so has `SuccessCount:1`), and the conditional repeating block coming off of it will thus activate every other tick.
+In 1.13+ you can check more things apart from selectors with [`execute if/unless`](https://minecraft.wiki/w/Commands/execute#Condition_subcommands)
 
-These cause no block updates and require no entities or scoreboard objectives, but are limited to halving the speed of the first block.
-
-More flexible and commonly used are scoreboard timers. One command continually increments a value, another tests when this value reaches a certain number, then the value is reset and a chain of commands is activated. 
-
-[Here's an example setup image.](http://i.imgur.com/fGyA294.png)
-
-These cause no block updates and require no entities, but will require an objective, and a new fake player for each timer. Scoreboard timers can also be used in functions.
-
-Other methods such as a falling block clock exist and can be convenient, but cause block updates, lighting updates, and requires an entity.
-
-**Functions** can be even easier to run on slower speeds, as the `schedule` command allows you to run functions after a certain amount of time has passed. You can use this for functions to schedule themselves to essentially create a slower clock.
-
-`code/slow_function.mcfunction`
+## Slow down your commands
+Not everything needs to be running at 20Hz. If you can run some commands at 10Hz instead, you've halved the impact those commands were having.
 
-    schedule function slow_function 10t
-    say this will run twice per second
+In Bedrock you can just add a delay to a repeating commandblock into the block directly, in Java you need some workaround that you can find in the questions ["How to add delay to a command"](/wiki/questions/blockdelay)
 
-you just need to start the function at some point (e.g. in the `#minecraft:load` function tag) and it will run at a slower speed.
+If you are using command blocks it is recomended to use the `SuccessCount` method to make them at half speed but if you are using datapacks, use schedule functions.
 
 ## Avoid chunk updates
 
@@ -106,7 +86,7 @@ Selectors are used a lot in commands. To make sure you're not causing extra work
 
 Your main aim here is to narrow down the list as much as possible before getting to the expensive distance-sorting/shuffling and especially the super expensive NBT checks. You shouldn't however unnecessarily check arguments that won't narrow down the list before distance-sorting/shuffling. For example, don't check `@e[type=zombie,tag=IsUndeadMob]` if all zombies will have that tag. You shouldn't make your selector imprecise so that it applies to more entities than it needs to, either. 
 
-`nbt` is the least efficient target selector, as it has to do a lot of converting and comparing, and as such should be avoided at (almost) all costs, or at least limited to the absolute minimum required.
+`nbt` is the least efficient target selector, as it has to do a lot of converting and comparing, and as such should be avoided at (almost) all costs, or at least limited to the absolute minimum required. [Predicates](https://minecraft.wiki/w/Predicate), in the other hand, can archive the same causing less performance impact only when not using NBT checks but built-in checks. If using NBT checks it actually performs worse. 
 
 `@s` is the most efficient selector, directly grabbing the command sender. See the section on **function-specific optimisations** for how you can make use of it to cut down on use of other selectors.
 
@@ -122,9 +102,9 @@ Using armor stands as markers? Strongly consider switching to area effect clouds
 
     summon area_effect_cloud ~ ~ ~ {Duration:2147483647}
 
-These won't show up to spectators, which is a bonus if you don't want spectators to see your markers. If you want to see them for debugging purposes, turn on hitboxes (`F3 + B`). Armor stands should only be used where necessary, such as displaying an item or using `Motion`.
+These won't show up to spectators, which is a bonus if you don't want spectators to see your markers. If you want to see them for debugging purposes, turn on hitboxes (`F3 + B`). Armor stands should only be used where necessary, such as displaying an item (In pre-1.19.4, as you can use item displays in newer versions) or using `Motion`.
 
-[Marker entities](https://minecraft.wiki/wiki/Marker) on the other hand are impossible to see, as they aren't even sent to the client, so you'd need to resort to other options to debug them. This however means that they have a competitive advantage when it comes to performance and should be used as a marker over the other options wherever possible.  
+[Marker entities](https://minecraft.wiki/wiki/Marker) on the other hand are impossible to see, as they aren't even sent to the client (unless using [a mod](https://modrinth.com/mod/visiblebarriers), that needs to be on the server as well), so you'd need to resort to other options to debug them. This however means that they have a competitive advantage when it comes to performance and should be used as a marker over the other options wherever possible.  
 Additionally they can store any kind of NBT data in their `data` NBT component (though storing abritrary data is probably better stored in the `storage` anyways).
 
 Remember from the previous section that selectors work by getting a list of all loaded entities, then narrowing that down. This means that extra entities increase the workload of every selector in your commands. In some cases, you could be able to use static coordinates rather than executing off of a marker entity. 
@@ -157,6 +137,6 @@ This means that instead of evaluating `@e[tag=blah]` many times, it is only eval
 
 ## More in-depth optimization
 
-/u/Wooden_chest created an in-depth analysis of a lot of small things that can improve your performance, like what order to put your execute subcommands into or that depending on the circumstance it might actually be faster to copy NBT you want to test to the storage first before testing it instead of testing it on the entity/player directly.
+[/u/Wooden_chest](https://www.reddit.com/user/Wooden_chest/) created an in-depth analysis of a lot of small things that can improve your performance, like what order to put your execute subcommands into or that depending on the circumstance it might actually be faster to copy NBT you want to test to the storage first before testing it instead of testing it on the entity/player directly.
 
-Read their full post here: https://www.reddit.com/r/MinecraftCommands/comments/w4vjs3/whenever_i_create_datapacks_i_sometimes_do/
+Read their full post here: https://www.reddit.com/r/MinecraftCommands/comments/w4vjs3/whenever_i_create_datapacks_i_sometimes_do/
@@ -4,6 +4,13 @@
 
 Because in 1.19.50, the [new execute syntax](https://learn.microsoft.com/en-us/minecraft/creator/documents/commandsnewexecute) became mandatory, so you'll need to switch to that. See also [this information on bedrock.dev](https://wiki.bedrock.dev/commands/new-execute.html).
 
+## Why is my give command broken (java)?
+In 1.20.5 a new system for storing item data has been introduced to Java Edition in [Snapshot 24w09a](https://www.minecraft.net/en-us/article/minecraft-snapshot-24w09a).
+Anything relating to items (such as /give, /item or loot tables) have a different format now.
+The gist of it is this: Unstructured NBT data attached to stacks of items (tag field) has been replaced with structured 'components' that go in [] and are comma separated.
+For example: /give @p diamond_pickaxe[damage=10,custom_model_data=7]
+For a list of how item components are structured, see [this article on the minecraft.wiki](https://minecraft.wiki/w/Item_format/1.20.5).
+
 ## How do I...
 
 ### Items
@@ -14,7 +21,8 @@ Because in 1.19.50, the [new execute syntax](https://learn.microsoft.com/en-us/m
 [Detect rightclick or leftclick (on an item)?](/wiki/questions/itemclick)  
 [Give a special item (Bedrock)?](/wiki/questions/giveitembedrock)  
 [Change an item while it's in the players inventory?](/wiki/questions/modifyinventory)  
-[Do custom crafting](/wiki/questions/customcrafting)
+[Do custom crafting?](/wiki/questions/customcrafting)  
+[Make a shop? / Buy items?](/wiki/questions/shop)
 
 ### Scores
 
@@ -25,7 +33,7 @@ Because in 1.19.50, the [new execute syntax](https://learn.microsoft.com/en-us/m
 [Summon/Teleport an entity/player at/to a position defined in a score?](/wiki/questions/movetoscore)  
 [Detect a change in score?](/wiki/questions/changeofscore)  
 [Link an entity to another entity through scoreboards?](/wiki/questions/linkentity)  
-[Find the player / entity with the highest score?](/wiki/questions/highestscore/)   
+[Find the player / entity with the highest / lowest score?](/wiki/questions/highestscore)   
 
 ### Players
 
@@ -50,8 +58,10 @@ Because in 1.19.50, the [new execute syntax](https://learn.microsoft.com/en-us/m
 [Make a scoreboard ID system?](/wiki/questions/linkentity)  
 [Make one mob attack another mob/player?](/wiki/questions/angermob)  
 [Do raycasting?](/wiki/questions/raycast)   
-[Make a circle (of blocks / entities)?](/wiki/questions/makecircle/)
-[Detect when a mob has died](/wiki/questions/mobdeaths)
+[Make a circle (of blocks / entities)?](/wiki/questions/makecircle)  
+[Detect when a mob has died](/wiki/questions/mobdeaths)  
+[Make hostile mobs friendly / dissable PvP](/wiki/questions/hostilefriendly)  
+[Setup, configure and add multiple dialogues to NPCs?](/wiki/questions/npc)
 
 ## What is...
 
@@ -67,4 +77,4 @@ Because in 1.19.50, the [new execute syntax](https://learn.microsoft.com/en-us/m
 
 ## Still needed articles
 
-*Found something that should be added? Maybe even want to contribute an article? Submit a pull request or create a GitHub issue.*
+*Found something that should be added? Maybe even want to contribute an article? Submit a pull request or create a GitHub issue [here](https://github.com/MinecraftCommands/wiki).*
@@ -52,6 +52,6 @@ Here are some examples for this:
 
 ## Bedrock
 
-In the **1.18.20 beta** they added the [`hasitem`](https://minecraft.wiki/wiki/Target_selectors#Selecting_targets_by_items) target selector, which allows you to check for specific amounts (as [ranges](/wiki/questions/range)) of items in entities inventories. Below is an example, check the link above for more information.
+In the **1.18.20 beta** they added the [`hasitem`](https://minecraft.wiki/wiki/Target_selectors#Selecting_targets_by_items) target selector, which allows you to check for specific amounts (as [ranges](/wiki/questions/range)) of items in entities inventories. Below is an example (using 1.19.50 execute), check the link above for more information.
 
-    execute @a[hasitem={item:apple,quantity=5..}] ~~~ run say I have 5 or more apples in my inventory
+    execute as @a[hasitem={item=apple,quantity=5..}] run say I have 5 or more apples in my inventory