Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfiledDbConnection: implement DisposeAsync #512

Open
bbarry opened this issue Jul 23, 2020 · 2 comments
Open

ProfiledDbConnection: implement DisposeAsync #512

bbarry opened this issue Jul 23, 2020 · 2 comments

Comments

@bbarry
Copy link

bbarry commented Jul 23, 2020

https://docs.microsoft.com/en-us/dotnet/api/system.data.common.dbconnection.disposeasync?view=netcore-3.1

relates to dotnet/runtime#28596

ProfiledDbConnection should implement DisposeAsync by delegating to the wrapped connection's version to gain async disposal on connections that support it.

@NickCraver
Copy link
Member

Are any providers using this today? Currently, MiniProfiler.Shared targets net461 and netstandard2.0, we'd need to add a netstandard2.1 build to expose this API, to trying to access value here :)

@bbarry
Copy link
Author

bbarry commented Jul 26, 2020

NpgSql 4.1.0 and MySqlConnector 0.57.0 currently support it.

There are open issues for Microsoft.Data.SqlClient and AdoNetCore.AseClient (Sybase/SAP doesn't have a .NET Core driver yet at all) and I have no idea about any official Oracle stuff.

I don't think this should be a high priority or anything, just noted on a list of things to do eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants