Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitpack packages should be generated at release time #1585

Closed
jcpitre opened this issue Sep 21, 2023 · 1 comment
Closed

Jitpack packages should be generated at release time #1585

jcpitre opened this issue Sep 21, 2023 · 1 comment
Labels
enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues

Comments

@jcpitre
Copy link
Contributor

jcpitre commented Sep 21, 2023

Describe the problem

In #1473 there was a problem for jitpack to build release 4.1.0 of the validator jars.
We should make sure jitpack builds the jars properly as part of the release.

Proposed solution

We need to have a dummy build with have this in build.gradle:

repositories {
   ...
    maven { url 'https://jitpack.io' }
    mavenCentral() // <2>
}

dependencies {
   ...
    implementation 'com.github.MobilityData:gtfs-validator:v4.1.0'
}

Adjust for the release tag (v4.1.0 in this case)
The project could have a simple "Hello World" java class.

This dummy build has to be executed as part of the release, ideally from a Github action.
Errors running the build should be reported and maybe block the release.

Alternatives you've considered

No response

Additional context

No response

@jcpitre jcpitre added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels Sep 21, 2023
@emmambd
Copy link
Contributor

emmambd commented Oct 24, 2023

Closing since jitpack has been replaced with Maven at #1596

@emmambd emmambd closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues
Projects
None yet
Development

No branches or pull requests

2 participants