Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required and recommended notices on files with no rows #1853

Open
davidgamez opened this issue Sep 26, 2024 · 1 comment
Open

Required and recommended notices on files with no rows #1853

davidgamez opened this issue Sep 26, 2024 · 1 comment

Comments

@davidgamez
Copy link
Member

Description

The missing_required_file and missing_recommended_file notices are triggered when the file is not in the feed. This doesn't cover files with headers and no rows. Having a file in the feed with no data(only headers) defeats the intention of the required and recommended notices, as it doesn't encourage producers to add the data.

Solution Proposed

Add additional notices _required_file_empty_ and _recommended_file_empty_ (or a better name) to express that the files are present but have no rows.

Alternative Solution

We can also modify the required and recommended notice to catch files with no rows. The downside is that consumers can be confused when providing a file with no rows and getting missing required or recommended file.

Example fee, https://mobilitydatabase.org/feeds/mdb-1147

@dancory-urbanfootprint
Copy link

Another example https://mobilitydatabase.org/feeds/mdb-340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants