Skip to content

Remove need for derive #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ModProg opened this issue Dec 8, 2021 · 2 comments · Fixed by #33
Closed

Remove need for derive #27

ModProg opened this issue Dec 8, 2021 · 2 comments · Fixed by #33
Assignees
@ModProg
Labels
enhancement New feature or request

Comments

@ModProg
Copy link
Owner

ModProg commented Dec 8, 2021

This could easily be done if rust-lang/rust#65823 was implemented.
@ModProg ModProg added blocked Blocked by external factors, at least with the proposed approach enhancement New feature or request labels Dec 8, 2021
@ModProg
Copy link
Owner Author

ModProg commented Jan 9, 2022

We decided to go forward with this, this will restrict renaming of the macro, maybe we'll have a bright idea to re-enable that if needed (e.g. via parameter)

@ModProg
Copy link
Owner Author

ModProg commented Jan 9, 2022

not to mention, that renaming was not possible while using derive anyway.

@ModProg ModProg self-assigned this Jan 9, 2022
@ModProg ModProg removed the blocked Blocked by external factors, at least with the proposed approach label Jan 9, 2022
@ModProg ModProg linked a pull request Jan 9, 2022 that will close this issue
derive_where attribute macro instead of derive macro #33
Merged
@ModProg ModProg mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ModProg ModProg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

derive_where attribute macro instead of derive macro ModProg/derive-where
1 participant
@ModProg