Merge pull request #188 from Modagbul/feat/block

seungueonn · web-flow · commit 1d2abc10b883 · 2024-01-05T02:09:24.000+09:00
fix : 반복미션 종료 로직 버그 수정
diff --git a/src/main/java/com/moing/backend/domain/missionState/application/service/MissionStateUseCase.java b/src/main/java/com/moing/backend/domain/missionState/application/service/MissionStateUseCase.java
@@ -42,7 +42,7 @@ public boolean isAbleToEnd(Long missionId) {
         Long total = totalPeople(mission);
         Long done = donePeople(mission);
 
-        return done.equals(total);
+        return done >= total;
 
     }
     public boolean isAbleToScoreUp(Long missionId) {
@@ -70,7 +70,7 @@ public Long totalPeople(Mission mission) {
     public void updateMissionState(Member member, Mission mission, MissionArchive missionArchive) {
 
         // 마지막 인증 시
-        if (isAbleToEnd(mission.getId())) {
+        if (mission.getType().equals(MissionType.ONCE) && isAbleToEnd(mission.getId())) {
             mission.updateStatus(MissionStatus.SUCCESS);
         }
         missionStateSaveService.saveMissionState(member,mission, missionArchive.getStatus());

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public boolean isAbleToEnd(Long missionId) {`
`42`	`42`	`Long total = totalPeople(mission);`
`43`	`43`	`Long done = donePeople(mission);`
`44`	`44`
`45`		`- return done.equals(total);`
	`45`	`+ return done >= total;`
`46`	`46`
`47`	`47`	`}`
`48`	`48`	`public boolean isAbleToScoreUp(Long missionId) {`
`@@ -70,7 +70,7 @@ public Long totalPeople(Mission mission) {`
`70`	`70`	`public void updateMissionState(Member member, Mission mission, MissionArchive missionArchive) {`
`71`	`71`
`72`	`72`	`// 마지막 인증 시`
`73`		`- if (isAbleToEnd(mission.getId())) {`
	`73`	`+ if (mission.getType().equals(MissionType.ONCE) && isAbleToEnd(mission.getId())) {`
`74`	`74`	`mission.updateStatus(MissionStatus.SUCCESS);`
`75`	`75`	`}`
`76`	`76`	`missionStateSaveService.saveMissionState(member,mission, missionArchive.getStatus());`