Skip to content

Commit 27495f2

Browse files
committed
refactor: 에러 발생 시 eventPublisher로 관리해 slackService 의존성 제거
1 parent b0b093a commit 27495f2

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/main/java/com/moing/backend/global/exception/GlobalExceptionHandler.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
package com.moing.backend.global.exception;
22

3+
import com.moing.backend.global.config.slack.exception.dto.ExceptionEvent;
34
import com.moing.backend.global.response.ErrorCode;
45
import com.moing.backend.global.response.ErrorResponse;
5-
import com.moing.backend.global.util.SlackService;
66
import lombok.RequiredArgsConstructor;
77
import lombok.extern.slf4j.Slf4j;
8+
import org.springframework.context.ApplicationEventPublisher;
9+
import org.springframework.context.support.DefaultMessageSourceResolvable;
810
import org.springframework.http.HttpStatus;
911
import org.springframework.http.ResponseEntity;
1012
import org.springframework.http.converter.HttpMessageNotReadableException;
1113
import org.springframework.web.HttpRequestMethodNotSupportedException;
1214
import org.springframework.web.bind.MethodArgumentNotValidException;
1315
import org.springframework.web.bind.annotation.ExceptionHandler;
1416
import org.springframework.web.bind.annotation.RestControllerAdvice;
15-
import org.springframework.context.support.DefaultMessageSourceResolvable;
1617

1718
import javax.servlet.http.HttpServletRequest;
1819
import java.util.function.Consumer;
@@ -25,7 +26,7 @@
2526
public class GlobalExceptionHandler {
2627

2728
private static final String LOG_FORMAT = "Class : {}, Code : {}, Message : {}";
28-
private final SlackService slackService;
29+
private final ApplicationEventPublisher eventPublisher;
2930

3031
@ExceptionHandler(ApplicationException.class)
3132
public ResponseEntity<ErrorResponse> handleApplicationException(ApplicationException ex) {
@@ -57,7 +58,7 @@ public ResponseEntity<ErrorResponse> httpRequestNotSupportedExceptionHandler(Htt
5758

5859
@ExceptionHandler(Exception.class)
5960
public ResponseEntity<ErrorResponse> internalServerErrorHandler(Exception ex, HttpServletRequest request) {
60-
slackService.sendSlackAlertErrorLog(ex, request);
61+
eventPublisher.publishEvent(new ExceptionEvent(request, ex));
6162
return handleException(ex, ErrorCode.INTERNAL_SERVER_ERROR, ErrorCode.INTERNAL_SERVER_ERROR.getMessage(), HttpStatus.INTERNAL_SERVER_ERROR, log::error);
6263
}
6364

src/test/java/com/moing/backend/config/CommonControllerTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.moing.backend.global.config.security.filter.JwtAuthenticationEntryPoint;
99
import com.moing.backend.global.config.security.jwt.TokenUtil;
1010
import com.moing.backend.global.config.security.util.AuthenticationUtil;
11-
import com.moing.backend.global.util.SlackService;
1211
import org.junit.jupiter.api.BeforeEach;
1312
import org.junit.jupiter.api.extension.ExtendWith;
1413
import org.springframework.beans.factory.annotation.Autowired;
@@ -58,9 +57,6 @@ public class CommonControllerTest {
5857
@MockBean
5958
public MemberGetService memberQueryService;
6059

61-
@MockBean
62-
private SlackService slackService;
63-
6460
@BeforeEach
6561
public void setUp(final WebApplicationContext context, final RestDocumentationContextProvider provider) throws Exception {
6662

0 commit comments

Comments
 (0)