Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible duplication #48

Open
lizliz opened this issue Jan 22, 2025 · 1 comment
Open

Possible duplication #48

lizliz opened this issue Jan 22, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@lizliz
Copy link
Contributor

lizliz commented Jan 22, 2025 •
edited
Loading

Looks like we have two functions doing essentially the same thing in the embedded graph class: set_scaled_coordinates and rescale_to_unit_disk. I found them after rearranging the code to put similar functions together. These need to be unified and/or removed as necessary.
@lizliz lizliz added the good first issue Good for newcomers label Jan 22, 2025
@Yemeen
Copy link
Member

Yemeen commented Jan 22, 2025

will fix in my rewrite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

vectorizedect MunchLab/ect
2 participants
@lizliz @Yemeen