Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS or AMD dependencies can cause optimization bailouts #454

Closed
Bykiev opened this issue Aug 18, 2022 · 4 comments · Fixed by #482
Closed

CommonJS or AMD dependencies can cause optimization bailouts #454

Bykiev opened this issue Aug 18, 2022 · 4 comments · Fixed by #482

Comments

@Bykiev
Copy link

Bykiev commented Aug 18, 2022

Hi, when building angular app there is an warning:

\node_modules\ngx-scrollbar\fesm2015\ngx-scrollbar-smooth-scroll.mjs depends on 'bezier-easing'. CommonJS or AMD dependencies can cause optimization bailouts.For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Can we replace bezier-easing dependency with smth else or patch it?

@MurhafSousli
Copy link
Owner

MurhafSousli commented Aug 20, 2022

We rely on this package for smooth scrolling, add the package to allowedCommonJsDependencies in your angular.json to get rid of that warning

"allowedCommonJsDependencies": [
"chance",
"bezier-easing"
],

@Bykiev
Copy link
Author

Bykiev commented Aug 21, 2022

I know about it, but such dependencies will cause optimization issues, I don't want use such libraries in my projects

@Sergiobop
Copy link

I just open gre/bezier-easing#51 to see if the owners can do something about this one @Bykiev

@MurhafSousli MurhafSousli linked a pull request May 21, 2023 that will close this issue
@MurhafSousli
Copy link
Owner

MurhafSousli commented May 21, 2023

In v12, bezier-easing has been removed from dependencies list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants