-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Play the XXX news" does not work as expected #129
Comments
Hey Denics, Apologies for the slow response, I've been away a bit and catching up on things. For phrases like "play the XXX news" this is routed through the Common Play System (CPS). It calls the In this case it's using this function to match names: skill-npr-news/stations/match.py Line 72 in 424f26e
So potentially there's something in there that's not working for translated strings? or it's not matching on the station name/acronym correctly. If you have specific example phrases (in Italian) we could add some unit tests to get a better idea of what's happening. |
Ok, but then that means that we will never have a correspondence in languages other than en-us. For example in Italian it should be able to play:
A dream would be to be able to say:
Thanks and sorry for pestering you, I know you are busy with Mark II, and I am really looking forward to it, this is why I decided to get my hands dirty :) |
No that should definitely be possible. The first one sounds like we just need to get the translations mapped correctly. It might be as simple as adding dimmi and dammi to give.voc? The second form isn't something that is supported yet but is a great idea. Not sure exactly when we'll get to it, but I've added a |
Hi @krisgesling I am a bit frustrated here. I tried to make my picroft tell me the Italian news in many way, but with no success :( |
Hi al,
in the examples, and in the code, it seems possible to ask mycroft to play the news from a specific source (my wife is spanish and I am italian, you can imagine).
However, I cannot make mycroft play any news if not from the default one, at least, in italian. I could not even find the intent for that.
The text was updated successfully, but these errors were encountered: