Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in Start View Entity Module #194

Closed
Malte96 opened this issue Jul 23, 2024 · 5 comments · Fixed by #226
Closed

Error handling in Start View Entity Module #194

Malte96 opened this issue Jul 23, 2024 · 5 comments · Fixed by #226
Assignees
Labels
bug Something isn't working

Comments

@Malte96
Copy link

Malte96 commented Jul 23, 2024

In the event of errors in the configuration of individual entities (e.g. invalid unit code), Entirety displays a general error message on the Entity Module start page. error_message

It would be great if the error message could indicate the affected entity and continue to display the error-free entities.

@djs0109
Copy link
Collaborator

djs0109 commented Jul 26, 2024

@Malte96, thanks for reporting. Could you provide a script or payload to create a list of imperfect entities? Then we can reproduce this issue more efficiently.

@Malte96
Copy link
Author

Malte96 commented Jul 29, 2024

Here is an example of how to create a faulty device (entity) with Postman:
Entirety_Error.postman_collection.json

@djs0109
Copy link
Collaborator

djs0109 commented Jul 30, 2024

ToDos:

  • [Entities] the list view should handle single validation error (give error message and specify which entity is causing the problem). This seems to require implementation on filip, since in backend, we use the function get_entity_list of filip. And this function is creating error.
  • [Devices] the list view should handle single validation error (give error message and specify which device is causing the problem)
  • [Devices] the multi devices creation has error
  • [Devices] ignore metadata or implement metadata
  • [Entities] add logging in get_table_data in List View

@djs0109 djs0109 added the bug Something isn't working label Oct 23, 2024
@djs0109 djs0109 added this to the Stability milestone Oct 23, 2024
@djs0109 djs0109 self-assigned this Oct 23, 2024
@djs0109
Copy link
Collaborator

djs0109 commented Dec 11, 2024

On hold, waiting for RWTH-EBC/FiLiP#335

@djs0109 djs0109 added the on hold Not prioritised label Dec 11, 2024
@djs0109 djs0109 changed the title Error in Start View Entity Module Error handling in Start View Entity Module Jan 15, 2025
@djs0109
Copy link
Collaborator

djs0109 commented Jan 15, 2025

wait for FiLiP release 0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants