From c087833fee4d15addb13ddd0369e9882205916fb Mon Sep 17 00:00:00 2001 From: Brian Carlsen Date: Thu, 16 Jan 2025 08:52:03 -0800 Subject: [PATCH] RDFBROWSER-525: fix issues with popout hierarchy (#325) --- web/build.gradle | 11 +- .../concept-display.component.ts | 7 +- .../evs-header/evs-header.component.html | 109 ++++++---- .../hierarchy-display.component.html | 40 ++-- .../hierarchy-display.component.ts | 141 +++++-------- .../hierarchy-popup.component.css | 6 + .../hierarchy-popup.component.html | 75 ++++--- .../hierarchy-popup.component.ts | 196 ++++++++---------- 8 files changed, 292 insertions(+), 293 deletions(-) diff --git a/web/build.gradle b/web/build.gradle index 656fefe2..ebc98fa6 100644 --- a/web/build.gradle +++ b/web/build.gradle @@ -67,15 +67,16 @@ dependencies { implementation 'org.springframework.boot:spring-boot-starter-web' implementation 'org.springframework.cloud:spring-cloud-starter-gateway-mvc' + implementation 'ch.qos.logback:logback-classic:1.4.14' // Updated version implementation 'ch.qos.logback:logback-core:1.4.14' // Updated version implementation 'org.springframework.boot:spring-boot-starter-tomcat:3.2.10' // Updated version implementation 'org.apache.tomcat:tomcat-annotations-api:10.1.30' // Updated version - implementation 'org.apache.tomcat.embed:tomcat-embed-core:10.1.30' // Updated version - implementation 'org.apache.tomcat.embed:tomcat-embed-el:10.1.30' // Updated version - implementation 'org.apache.tomcat.embed:tomcat-embed-websocket:10.1.30' // Updated version - implementation 'org.springframework:spring-web:6.1.13' // Updated version - implementation 'org.springframework:spring-webmvc:6.1.13' // Updated version + implementation 'org.apache.tomcat.embed:tomcat-embed-core:10.1.34' // Updated version + implementation 'org.apache.tomcat.embed:tomcat-embed-el:10.1.34' // Updated version + implementation 'org.apache.tomcat.embed:tomcat-embed-websocket:10.1.34' // Updated version + implementation 'org.springframework:spring-web:6.1.14' // Updated version + implementation 'org.springframework:spring-webmvc:6.1.14' // Updated version // fixes netty resolver error for macos implementation 'io.netty:netty-common:4.1.115.Final' implementation 'io.netty:netty-resolver-dns-native-macos' diff --git a/web/frontend/src/app/component/concept-display/concept-display.component.ts b/web/frontend/src/app/component/concept-display/concept-display.component.ts index 4eb7a922..444af2b3 100644 --- a/web/frontend/src/app/component/concept-display/concept-display.component.ts +++ b/web/frontend/src/app/component/concept-display/concept-display.component.ts @@ -1,5 +1,5 @@ -import {Component, OnDestroy, OnInit} from '@angular/core'; -import {NavigationEnd, Router} from '@angular/router'; +import { Component, OnDestroy, OnInit } from '@angular/core'; +import { NavigationEnd, Router } from '@angular/router'; import { Location } from '@angular/common'; import { ConceptDetailService } from './../../service/concept-detail.service'; import { Concept } from './../../model/concept'; @@ -60,7 +60,6 @@ export class ConceptDisplayComponent implements OnInit, OnDestroy { conceptIsSubset: boolean; hierarchyPopupUrl = '/hierarchy-popup/'; - subscription = null; constructor( @@ -119,7 +118,7 @@ export class ConceptDisplayComponent implements OnInit, OnDestroy { if (this.configService.getTriggerHierarchyPopup()) { const baseHref = this.location.prepareExternalUrl(''); const url = this.router.createUrlTree([baseHref + this.hierarchyPopupUrl + this.terminology + '/' + this.conceptCode]).toString(); - window.open(url, '_blank', 'width=600,height=1000'); + window.open(url, '_blank', 'width=600,height=850,scrolbars=no'); this.configService.setTriggerHierarchyPopup(false); } } diff --git a/web/frontend/src/app/component/evs-header/evs-header.component.html b/web/frontend/src/app/component/evs-header/evs-header.component.html index bdd0b9de..d572dba8 100644 --- a/web/frontend/src/app/component/evs-header/evs-header.component.html +++ b/web/frontend/src/app/component/evs-header/evs-header.component.html @@ -1,78 +1,101 @@ -