Remove fetch daos function #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies * Fix flashes * Fix daosdk fallback * Remove unused files and comments * Formatting fix
itexpert120
requested review from
Megha-Dev-19,
Jikugodwill,
elliotBraem and
saadiqbal-dev
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jikugodwill
reviewed
May 3, 2024
| }; | ||
|
|
||
| const DaoSDK = VM.require("sdks.near/widget/SDKs.Sputnik.DaoSDK") || (() => {}); | ||
| const sdk = DaoSDK("build.sputnik-dao.near"); |
There was a problem hiding this comment.
Perhaps this could also be added to aliases?
Suggested change
| const sdk = DaoSDK("build.sputnik-dao.near"); | |
| const sdk = DaoSDK("${alias_buildDAO}"); |
| daos: [], | ||
| }; | ||
|
|
||
| const DaoSDK = VM.require("sdks.near/widget/SDKs.Sputnik.DaoSDK") || (() => {}); |
There was a problem hiding this comment.
How about placing this as "daosdk": "sdks.near/widget/SDKs.Sputnik.DaoSDK" in aliases (mainnet and testnet) and use ${alias_daosdk} instead?
Suggested change
| const DaoSDK = VM.require("sdks.near/widget/SDKs.Sputnik.DaoSDK") || (() => {}); | |
| const DaoSDK = VM.require("${alias_daosdk") || (() => {}); |
|
hey @itexpert120 I have added a comment to the SDK PR. |
|
Should be reopened, too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires NEARBuilders/sdks.near#19
Resolves #281