Add CI workflow and fix discovered issues. (#7)

Author: partim

.github/workflows/ci.yml

@@ -0,0 +1,39 @@
+name: ci
+on: [push, pull_request]
+jobs:
+  test:
+    name: test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macOS-latest]
+        rust: [1.56.1, stable, beta, nightly]
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v1
+    - name: Install Rust
+      uses: hecrj/setup-rust-action@v1
+      with:
+        rust-version: ${{ matrix.rust }}
+
+    # Because of all the features, we run build and test twice -- once with
+    # full features and once without any features at all -- to make it more
+    # likely that everything works.
+
+    # Clippy.
+    #
+    # Only do this once with all features enabled.
+    # Only do Clippy on stable for the moment, due to
+    # clippy::unknown_clippy_lints being removed.
+    - if: matrix.rust == 'stable'
+      run: rustup component add clippy
+    - if: matrix.rust == 'stable'
+      run: cargo clippy --all --all-features -- -D warnings
+
+    # Build
+    - run: cargo build --verbose --all --all-features
+    - run: cargo build --verbose --all
+
+    # Test
+    - run: cargo test --verbose --all --all-features
+

src/str.rs

@@ -29,6 +29,11 @@ impl<Octets> Str<Octets> {
     }
 
     /// Converts a sequence of octets into a string without checking.
+    ///
+    /// # Safety
+    ///
+    /// The caller must make sure that the contents of `octets` is a
+    /// correctly encoded UTF-8 string.
     pub unsafe fn from_utf8_unchecked(octets: Octets) -> Self {
         Self(octets)
     }
@@ -264,7 +269,7 @@ impl<Octets> StrBuilder<Octets> {
                 Some(len) => &octets[err.valid_up_to() + len ..],
                 None => b""
             };
-            err = match str::from_utf8(octets.as_ref()) {
+            err = match str::from_utf8(octets) {
                 Ok(_) => {
                     res.try_append_slice(octets)?;
                     break;
@@ -411,6 +416,15 @@ impl<Octets> StrBuilder<Octets> {
 }
 
 
+//-- Default
+
+impl<Octets: EmptyBuilder> Default for StrBuilder<Octets> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
+
 //--- Deref, DerefMut, AsRef, AsMut, Borrow, BorrowMut
 
 impl<Octets: AsRef<[u8]>> ops::Deref for StrBuilder<Octets> {

src/traits.rs

@@ -44,7 +44,7 @@
 //! could be defined like so:
 //!
 //! ```
-//! # use octets::OctetsRef;
+//! # use octseq::OctetsRef;
 //!
 //! fn take_part<'a, Octets>(
 //!     src: &'a Octets

src/types.rs

@@ -182,7 +182,7 @@ impl<const N: usize> FromBuilder for Array<N> {
 
 //--- OctetsFrom
 
-impl<const N: usize, Source: AsRef<[u8]>> OctetsFrom<Source> for Array<N> {
+impl<Source: AsRef<[u8]>, const N: usize> OctetsFrom<Source> for Array<N> {
     type Error = ShortBuf;
 
     fn try_octets_from(source: Source) -> Result<Self, Self::Error> {