add deprecation notice ; remove the easy way out for the flag

Author: scarlehoff

n3fit/src/n3fit/scripts/n3fit_exec.py

@@ -159,9 +159,6 @@ def from_yaml(cls, o, *args, **kwargs):
             N3FIT_FIXED_CONFIG['use_thcovmat_in_sampling'] = thconfig.get(
                 'use_thcovmat_in_sampling', True
             )
-        # TODO: this whole function is upside down?
-        N3FIT_FIXED_CONFIG["allow_legacy_names"] = file_content.get("allow_legacy_names", False)
-        # Fitting flag
         file_content.update(N3FIT_FIXED_CONFIG)
         return cls(file_content, *args, **kwargs)
 

nnpdf_data/nnpdf_data/__init__.py

@@ -1,8 +1,11 @@
 from functools import lru_cache
+import logging
 import pathlib
 
 import yaml
 
+log = logging.getLogger(__name__)
+
 path_vpdata = pathlib.Path(__file__).parent
 path_commondata = path_vpdata / "commondata"
 
@@ -18,6 +21,13 @@
 }
 
 
+@lru_cache
+def _warn_old_names():
+    log.warning(
+        "The usage of old names is deprecated and support will be dropped in future versions! Update your runcards"
+    )
+
+
 @lru_cache
 def legacy_to_new_map(dataset_name, sys=None):
     """Find the new dataset name and variant corresponding to an old dataset
@@ -35,6 +45,13 @@ def legacy_to_new_map(dataset_name, sys=None):
             )
         variant += f"_{sys}"
 
+    # Deprecation notice
+    _warn_old_names()
+    warn_text = f"Please change {dataset_name} to {new_name}"
+    if variant is None:
+        warn_text += f" (variant: {variant})"
+    log.warning(warn_text)
+
     return new_name, variant