Skip to content

Commit dc3de13

Browse files
committed
added docstrings to multiclosure
1 parent 63dea4a commit dc3de13

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

validphys2/src/validphys/closuretest/multiclosure.py

+14-6
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,12 @@
1010

1111
import numpy as np
1212
import dataclasses
13-
import pandas as pd
1413

1514
from reportengine import collect
1615
import validphys
1716
from validphys.calcutils import calc_chi2
18-
from validphys import covmats
1917
from validphys.checks import check_use_t0
2018
from validphys.closuretest.closure_checks import (
21-
check_at_least_10_fits,
2219
check_fits_areclosures,
2320
check_fits_different_filterseed,
2421
check_fits_underlying_law_match,
@@ -437,22 +434,33 @@ def compute_normalized_bias(
437434

438435
def bias_dataset(regularized_multiclosure_dataset_loader):
439436
"""
440-
TODO: comment this function properly
437+
Computes the normalized bias for a RegularizedMulticlosureLoader object
438+
for a single dataset.
439+
440+
Parameters
441+
----------
442+
regularized_multiclosure_dataset_loader : RegularizedMulticlosureLoader
443+
444+
Returns
445+
-------
446+
tuple
447+
bias_fits
448+
n_comp
441449
"""
442450
bias_fits = compute_normalized_bias(regularized_multiclosure_dataset_loader, corrmat=False)
443451
n_comp = regularized_multiclosure_dataset_loader.n_comp
444452
return bias_fits / n_comp, n_comp
445453

446454

447455
"""
448-
TODO
456+
Collects the bias data for all datasets.
449457
"""
450458
bias_datasets = collect("bias_dataset", ("data",))
451459

452460

453461
def bias_data(regularized_multiclosure_data_loader):
454462
"""
455-
TODO: comment
463+
Similar to `bias_dataset` but for all data.
456464
"""
457465
bias_fits = compute_normalized_bias(regularized_multiclosure_data_loader, corrmat=True)
458466
n_comp = regularized_multiclosure_data_loader.n_comp

0 commit comments

Comments
 (0)