Skip to content

Commit

Permalink
Address lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidHuber-NOAA committed Feb 10, 2025
1 parent e109669 commit 49ba53f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions parm/globus/init_xfer.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,10 @@ if [[ ${diff_d} -gt 3 ]]; then
echo "WARNING the {{SERVER_NAME}} service for {{PSLOT}} has not run in > 3 days!"
echo "Turning off the crontab for {{PSLOT}}!!"
scriptpath="$( realpath "${0}" )"
entry=$(crontab -l | grep -i "${scriptpath}")
cron_out=$(crontab -l)

Check notice

Code scanning / shellcheck

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). Note

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).
entry=$(crontab -l | grep "${scriptpath}")
echo "Deleting crontab entry"
echo "${entry}"
crontab -l | grep -v "${scriptpath}" | crontab -
cron_in=$(echo "${cron_out}" | grep -v "${scriptpath}")
echo "${cron_in}" | crontab -l
fi
3 changes: 2 additions & 1 deletion parm/globus/run_doorman.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,14 @@ fi
set -e

# Parse the FLIST file created by receive.sh to get the transfer IDs
packages=$(grep "package_location" FLIST)
IDs=""
while IFS= read -r line; do
package_name=$(echo "${line}" | grep -o "package_location_.*\.tgz")
tmp="${package_name#package_location_}"
ID="${tmp%.tgz}"
IDs="${IDs} ${ID}"
done < <(grep "package_location" FLIST)
done < <"(echo ${packages})"

Check failure

Code scanning / shellcheck

Couldn't parse this redirection. Fix to allow more checks. Error

Couldn't parse this redirection. Fix to allow more checks.

Check failure

Code scanning / shellcheck

Fix any mentioned problems and try again. Error

Fix any mentioned problems and try again.

set +e

Expand Down

0 comments on commit 49ba53f

Please sign in to comment.