Merge pull request #1750 from NREL/max_power_ratio_with_unit_multipliers

Allow maximum power ratio schedule w/ unit multipliers

Author: shorowit

.github/pull_request_template.md

@@ -4,9 +4,7 @@
 
 ## Checklist
 
-PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply. 
-
-PR Reviewer: Verify each has been completed.
+Not all may apply:
 
 - [ ] Schematron validator (`EPvalidator.xml`) has been updated
 - [ ] Sample files have been added/updated (`openstudio tasks.rb update_hpxmls`)

Changelog.md

@@ -2,6 +2,8 @@
 
 __New Features__
 - Adds inputs for modeling skylight curbs and/or shafts.
+- Advanced research features:
+  - Maximum power ratio detailed schedule for variable-speed HVAC systems can now be used with `NumberofUnits` dwelling unit multiplier.
 
 __Bugfixes__
 - Allows additional flexibility for multiple `Attic`/`Foundation` elements.

HPXMLtoOpenStudio/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>hpxm_lto_openstudio</name>
   <uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
-  <version_id>0aa3e855-c01f-41f6-9df5-367556f18455</version_id>
-  <version_modified>2024-06-17T15:28:30Z</version_modified>
+  <version_id>381502ab-7765-4f0b-a10b-78f2efc7bfd3</version_id>
+  <version_modified>2024-06-17T18:00:58Z</version_modified>
   <xml_checksum>D8922A73</xml_checksum>
   <class_name>HPXMLtoOpenStudio</class_name>
   <display_name>HPXML to OpenStudio Translator</display_name>
@@ -381,7 +381,7 @@
       <filename>hvac.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>A7D0B1CD</checksum>
+      <checksum>9931AEE6</checksum>
     </file>
     <file>
       <filename>hvac_sizing.rb</filename>
@@ -711,7 +711,7 @@
       <filename>test_validation.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>F0DB0351</checksum>
+      <checksum>32DEB854</checksum>
     </file>
     <file>
       <filename>test_water_heater.rb</filename>

HPXMLtoOpenStudio/resources/hvac.rb

@@ -227,7 +227,7 @@ def self.apply_air_source_hvac_systems(model, runner, cooling_system, heating_sy
 
     apply_installation_quality(model, heating_system, cooling_system, air_loop_unitary, htg_coil, clg_coil, control_zone)
 
-    apply_max_power_EMS(model, runner, hpxml_bldg, air_loop_unitary, control_zone, heating_system, cooling_system, htg_supp_coil, clg_coil, htg_coil, schedules_file)
+    apply_max_power_EMS(model, runner, air_loop_unitary, control_zone, heating_system, cooling_system, htg_supp_coil, clg_coil, htg_coil, schedules_file)
 
     if is_heatpump && hpxml_header.defrost_model_type == HPXML::AdvancedResearchDefrostModelTypeAdvanced
       apply_advanced_defrost(model, htg_coil, air_loop_unitary, control_zone.spaces[0], htg_supp_coil, cooling_system, q_dot_defrost)
@@ -2094,7 +2094,6 @@ def self.disaggregate_fan_or_pump(model, fan_or_pump, htg_object, clg_object, ba
   #
   # @param model [OpenStudio::Model::Model] OpenStudio Model object
   # @param runner [OpenStudio::Measure::OSRunner] OpenStudio Runner object
-  # @param hpxml_bldg [HPXML::Building] HPXML Building object representing an individual dwelling unit
   # @param air_loop_unitary [TODO] TODO
   # @param control_zone [TODO] TODO
   # @param heating_system [TODO] TODO
@@ -2104,15 +2103,11 @@ def self.disaggregate_fan_or_pump(model, fan_or_pump, htg_object, clg_object, ba
   # @param htg_coil [TODO] TODO
   # @param schedules_file [SchedulesFile] SchedulesFile wrapper class instance of detailed schedule files
   # @return [TODO] TODO
-  def self.apply_max_power_EMS(model, runner, hpxml_bldg, air_loop_unitary, control_zone, heating_system, cooling_system, htg_supp_coil, clg_coil, htg_coil, schedules_file)
+  def self.apply_max_power_EMS(model, runner, air_loop_unitary, control_zone, heating_system, cooling_system, htg_supp_coil, clg_coil, htg_coil, schedules_file)
     return if schedules_file.nil?
     return if clg_coil.nil? && htg_coil.nil?
 
     max_pow_ratio_sch = schedules_file.create_schedule_file(model, col_name: SchedulesFile::Columns[:HVACMaximumPowerRatio].name, schedule_type_limits_name: Constants.ScheduleTypeLimitsFraction)
-    # Not allowed with unit multiplier for now
-    if not max_pow_ratio_sch.nil?
-      fail 'NumberofUnits greater than 1 is not supported for maximum power ratio schedules of variable speed hvac systems.' if hpxml_bldg.building_construction.number_of_units > 1
-    end
     return if max_pow_ratio_sch.nil?
 
     # Check maximum power ratio schedules only used in var speed systems,

HPXMLtoOpenStudio/tests/test_validation.rb

@@ -1060,7 +1060,6 @@ def test_ruby_error_messages
                             'schedule-detailed-duplicate-columns' => ["Schedule column name 'occupants' is duplicated."],
                             'schedule-detailed-wrong-filename' => ["Schedules file path 'invalid-wrong-filename.csv' does not exist."],
                             'schedule-detailed-wrong-rows' => ["Schedule has invalid number of rows (8759) for column 'occupants'. Must be one of: 8760, 17520, 26280, 35040, 43800, 52560, 87600, 105120, 131400, 175200, 262800, 525600."],
-                            'schedule-file-max-power-ratio-with-unit-multiplier' => ['NumberofUnits greater than 1 is not supported for maximum power ratio schedules of variable speed hvac systems.'],
                             'skylight-not-connected-to-cond-space' => ["Skylight 'Skylight1' not connected to conditioned space; if it's a skylight with a shaft, use AttachedToFloor to connect it to conditioned space."],
                             'solar-thermal-system-with-combi-tankless' => ["Water heating system 'WaterHeatingSystem1' connected to solar thermal system 'SolarThermalSystem1' cannot be a space-heating boiler."],
                             'solar-thermal-system-with-desuperheater' => ["Water heating system 'WaterHeatingSystem1' connected to solar thermal system 'SolarThermalSystem1' cannot be attached to a desuperheater."],
@@ -1464,9 +1463,6 @@ def test_ruby_error_messages
         csv_data = CSV.read(File.join(File.dirname(hpxml.hpxml_path), hpxml_bldg.header.schedules_filepaths[0]))
         File.write(@tmp_csv_path, csv_data[0..-2].map(&:to_csv).join)
         hpxml_bldg.header.schedules_filepaths = [@tmp_csv_path]
-      elsif ['schedule-file-max-power-ratio-with-unit-multiplier'].include? error_case
-        hpxml, hpxml_bldg = _create_hpxml('base-hvac-mini-split-heat-pump-ducted-max-power-ratio-schedule.xml')
-        hpxml_bldg.building_construction.number_of_units = 2
       elsif ['skylight-not-connected-to-cond-space'].include? error_case
         hpxml, hpxml_bldg = _create_hpxml('base-enclosure-garage.xml')
         hpxml_bldg.skylights.add(id: 'Skylight1',

docs/source/workflow_inputs.rst

@@ -605,8 +605,6 @@ Building construction is entered in ``/HPXML/Building/BuildingDetails/BuildingSu
          
          \- Ground-source heat pumps
          
-         \- HVAC maximum power ratio schedules for variable speed hvac systems (see :ref:`schedules_detailed`)
-         
   .. [#] If NumberofBathrooms not provided, calculated as NumberofBedrooms/2 + 0.5 based on the `2010 BAHSP <https://www1.eere.energy.gov/buildings/publications/pdfs/building_america/house_simulation.pdf>`_.
   .. [#] If ConditionedBuildingVolume not provided, defaults to ConditionedFloorArea * AverageCeilingHeight + ConditionedCrawlspaceVolume.
 

workflow/tests/util.rb

@@ -46,9 +46,6 @@ def _run_xml(xml, worker_num, apply_unit_multiplier = false, annual_results_1x =
       elsif hpxml_bldg.heat_pumps.select { |hp| hp.heat_pump_type == HPXML::HVACTypeHeatPumpGroundToAir }.size > 0
         # FUTURE: GSHPs currently don't give desired results w/ unit multipliers
         # https://github.com/NREL/OpenStudio-HPXML/issues/1499
-      elsif xml.include? 'max-power-ratio-schedule'
-        # FUTURE: Maximum power ratio schedule currently gives inconsistent component load results w/ unit multipliers
-        # https://github.com/NREL/OpenStudio-HPXML/issues/1610
       elsif hpxml_bldg.batteries.size > 0
         # FUTURE: Batteries currently don't work with whole SFA/MF buildings
         # https://github.com/NREL/OpenStudio-HPXML/issues/1499