Skip to content

Commit f53e307

Browse files
joseph-robertsonjoseph-robertson
committed
Change default pipe diameter from 3/4in to 1-1/4in.
1 parent c15a7be commit f53e307

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎HPXMLtoOpenStudio/measure.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<schema_version>3.1</schema_version>
44
<name>hpxm_lto_openstudio</name>
55
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
6-
<version_id>439b78e6-5517-4d64-94bc-b54dfd43184f</version_id>
7-
<version_modified>2023-11-21T14:12:38Z</version_modified>
6+
<version_id>1514c9e1-0bfb-46e3-a387-64747abce65c</version_id>
7+
<version_modified>2023-11-21T14:20:22Z</version_modified>
88
<xml_checksum>D8922A73</xml_checksum>
99
<class_name>HPXMLtoOpenStudio</class_name>
1010
<display_name>HPXML to OpenStudio Translator</display_name>
@@ -310,7 +310,7 @@
310310
<filename>hpxml_defaults.rb</filename>
311311
<filetype>rb</filetype>
312312
<usage_type>resource</usage_type>
313-
<checksum>9EB5ED81</checksum>
313+
<checksum>BD06EC17</checksum>
314314
</file>
315315
<file>
316316
<filename>hpxml_schema/HPXML.xsd</filename>
@@ -592,7 +592,7 @@
592592
<filename>test_defaults.rb</filename>
593593
<filetype>rb</filetype>
594594
<usage_type>test</usage_type>
595-
<checksum>66B8B3DA</checksum>
595+
<checksum>B55E9CFA</checksum>
596596
</file>
597597
<file>
598598
<filename>test_enclosure.rb</filename>

‎HPXMLtoOpenStudio/resources/hpxml_defaults.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1582,7 +1582,7 @@ def self.apply_hvac(runner, hpxml, hpxml_bldg, weather, convert_shared_systems)
15821582
end
15831583

15841584
if heat_pump.geothermal_loop.pipe_diameter.nil?
1585-
heat_pump.geothermal_loop.pipe_diameter = 0.75 # in
1585+
heat_pump.geothermal_loop.pipe_diameter = 1.25 # in
15861586
heat_pump.geothermal_loop.pipe_diameter_isdefaulted = true
15871587
end
15881588

‎HPXMLtoOpenStudio/tests/test_defaults.rb‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1760,74 +1760,74 @@ def test_geothermal_loops
17601760
hpxml_bldg.geothermal_loops[0].bore_config = nil
17611761
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
17621762
_default_hpxml, default_hpxml_bldg = _test_measure()
1763-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1763+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
17641764

17651765
# Test defaults w/ specified loop flow
17661766
hpxml_bldg.geothermal_loops[0].loop_flow = 1
17671767
hpxml_bldg.geothermal_loops[0].num_bore_holes = nil
17681768
hpxml_bldg.geothermal_loops[0].bore_length = nil
17691769
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
17701770
_default_hpxml, default_hpxml_bldg = _test_measure()
1771-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 1, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1771+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 1, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
17721772

17731773
# Test defaults w/ specified num bore holes
17741774
hpxml_bldg.geothermal_loops[0].loop_flow = nil
17751775
hpxml_bldg.geothermal_loops[0].num_bore_holes = 2
17761776
hpxml_bldg.geothermal_loops[0].bore_length = nil
17771777
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
17781778
_default_hpxml, default_hpxml_bldg = _test_measure()
1779-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 2, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1779+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 2, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
17801780

17811781
# Test defaults w/ specified bore length
17821782
hpxml_bldg.geothermal_loops[0].loop_flow = nil
17831783
hpxml_bldg.geothermal_loops[0].num_bore_holes = nil
17841784
hpxml_bldg.geothermal_loops[0].bore_length = 300
17851785
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
17861786
_default_hpxml, default_hpxml_bldg = _test_measure()
1787-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, 300, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1787+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, 300, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
17881788

17891789
# Test defaults w/ specified loop flow, num bore holes
17901790
hpxml_bldg.geothermal_loops[0].loop_flow = 2
17911791
hpxml_bldg.geothermal_loops[0].num_bore_holes = 3
17921792
hpxml_bldg.geothermal_loops[0].bore_length = nil
17931793
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
17941794
_default_hpxml, default_hpxml_bldg = _test_measure()
1795-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 2, 3, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1795+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 2, 3, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
17961796

17971797
# Test defaults w/ specified num bore holes, bore length
17981798
hpxml_bldg.geothermal_loops[0].loop_flow = nil
17991799
hpxml_bldg.geothermal_loops[0].num_bore_holes = 4
18001800
hpxml_bldg.geothermal_loops[0].bore_length = 400
18011801
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
18021802
_default_hpxml, default_hpxml_bldg = _test_measure()
1803-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 4, 16.4, 400, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1803+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 4, 16.4, 400, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
18041804

18051805
# Test defaults w/ specified loop flow, bore length
18061806
hpxml_bldg.geothermal_loops[0].loop_flow = 5
18071807
hpxml_bldg.geothermal_loops[0].num_bore_holes = nil
18081808
hpxml_bldg.geothermal_loops[0].bore_length = 450
18091809
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
18101810
_default_hpxml, default_hpxml_bldg = _test_measure()
1811-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 5, nil, 16.4, 450, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1811+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 5, nil, 16.4, 450, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
18121812

18131813
# Test defaults w/ thermally enhanced grout type
18141814
hpxml_bldg.geothermal_loops[0].grout_type = HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced
18151815
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
18161816
_default_hpxml, default_hpxml_bldg = _test_measure()
1817-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1817+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
18181818

18191819
# Test defaults w/ thermally enhanced pipe type
18201820
hpxml_bldg.geothermal_loops[0].pipe_type = HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced
18211821
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
18221822
_default_hpxml, default_hpxml_bldg = _test_measure()
1823-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1823+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
18241824

18251825
# Test defaults w/ specified rectangle bore config
18261826
hpxml_bldg.geothermal_loops[0].num_bore_holes = nil
18271827
hpxml_bldg.geothermal_loops[0].bore_config = HPXML::GeothermalLoopBorefieldConfigurationRectangle
18281828
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
18291829
_default_hpxml, default_hpxml_bldg = _test_measure()
1830-
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
1830+
_test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle)
18311831
end
18321832

18331833
def test_hvac_location

‎docs/source/workflow_inputs.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2290,7 +2290,7 @@ Each geothermal loop is entered as an ``/HPXML/Building/BuildingDetails/Systems/
22902290
``BoreholesOrTrenches/Diameter`` double in > 0 No 5.0
22912291
``Grout/Type`` or ``Grout/Conductivity`` string or double Btu/hr-ft-F See [#]_ or > 0 No standard Grout type or conductivity [#]_
22922292
``Pipe/Type`` or ``Pipe/Conductivity`` string or double Btu/hr-ft-F See [#]_ or > 0 No standard Pipe type or conductivity [#]_
2293-
``Pipe/Diameter`` double in See [#]_ No 0.75
2293+
``Pipe/Diameter`` double in See [#]_ No 1.25
22942294
``Pipe/ShankSpacing`` double in > 0 No See [#]_ Center-to-center distance between two branches of a vertical U-tube
22952295
``extension/BorefieldConfiguration`` string See [#]_ No Rectangle
22962296
======================================== ================ =========== =============== ======== ============== ===============================================

0 commit comments

Comments
 (0)