From f53e30728be2513173088db0adf099edbd2db585 Mon Sep 17 00:00:00 2001 From: Joe Robertson Date: Tue, 21 Nov 2023 07:23:33 -0700 Subject: [PATCH] Change default pipe diameter from 3/4in to 1-1/4in. --- HPXMLtoOpenStudio/measure.xml | 8 ++++---- HPXMLtoOpenStudio/resources/hpxml_defaults.rb | 2 +- HPXMLtoOpenStudio/tests/test_defaults.rb | 20 +++++++++---------- docs/source/workflow_inputs.rst | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/HPXMLtoOpenStudio/measure.xml b/HPXMLtoOpenStudio/measure.xml index 42c46f4a5a..c915db0a3e 100644 --- a/HPXMLtoOpenStudio/measure.xml +++ b/HPXMLtoOpenStudio/measure.xml @@ -3,8 +3,8 @@ 3.1 hpxm_lto_openstudio b1543b30-9465-45ff-ba04-1d1f85e763bc - 439b78e6-5517-4d64-94bc-b54dfd43184f - 2023-11-21T14:12:38Z + 1514c9e1-0bfb-46e3-a387-64747abce65c + 2023-11-21T14:20:22Z D8922A73 HPXMLtoOpenStudio HPXML to OpenStudio Translator @@ -310,7 +310,7 @@ hpxml_defaults.rb rb resource - 9EB5ED81 + BD06EC17 hpxml_schema/HPXML.xsd @@ -592,7 +592,7 @@ test_defaults.rb rb test - 66B8B3DA + B55E9CFA test_enclosure.rb diff --git a/HPXMLtoOpenStudio/resources/hpxml_defaults.rb b/HPXMLtoOpenStudio/resources/hpxml_defaults.rb index ee8dec91a8..1a7709bd7e 100644 --- a/HPXMLtoOpenStudio/resources/hpxml_defaults.rb +++ b/HPXMLtoOpenStudio/resources/hpxml_defaults.rb @@ -1582,7 +1582,7 @@ def self.apply_hvac(runner, hpxml, hpxml_bldg, weather, convert_shared_systems) end if heat_pump.geothermal_loop.pipe_diameter.nil? - heat_pump.geothermal_loop.pipe_diameter = 0.75 # in + heat_pump.geothermal_loop.pipe_diameter = 1.25 # in heat_pump.geothermal_loop.pipe_diameter_isdefaulted = true end diff --git a/HPXMLtoOpenStudio/tests/test_defaults.rb b/HPXMLtoOpenStudio/tests/test_defaults.rb index 0cfae5f282..96f8e99f24 100644 --- a/HPXMLtoOpenStudio/tests/test_defaults.rb +++ b/HPXMLtoOpenStudio/tests/test_defaults.rb @@ -1760,7 +1760,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_config = nil XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified loop flow hpxml_bldg.geothermal_loops[0].loop_flow = 1 @@ -1768,7 +1768,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = nil XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 1, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 1, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified num bore holes hpxml_bldg.geothermal_loops[0].loop_flow = nil @@ -1776,7 +1776,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = nil XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 2, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 2, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified bore length hpxml_bldg.geothermal_loops[0].loop_flow = nil @@ -1784,7 +1784,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = 300 XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, 300, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, 300, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified loop flow, num bore holes hpxml_bldg.geothermal_loops[0].loop_flow = 2 @@ -1792,7 +1792,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = nil XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 2, 3, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 2, 3, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified num bore holes, bore length hpxml_bldg.geothermal_loops[0].loop_flow = nil @@ -1800,7 +1800,7 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = 400 XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 4, 16.4, 400, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, 4, 16.4, 400, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified loop flow, bore length hpxml_bldg.geothermal_loops[0].loop_flow = 5 @@ -1808,26 +1808,26 @@ def test_geothermal_loops hpxml_bldg.geothermal_loops[0].bore_length = 450 XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 5, nil, 16.4, 450, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, 5, nil, 16.4, 450, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.4, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ thermally enhanced grout type hpxml_bldg.geothermal_loops[0].grout_type = HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeStandard, 0.23, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ thermally enhanced pipe type hpxml_bldg.geothermal_loops[0].pipe_type = HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) # Test defaults w/ specified rectangle bore config hpxml_bldg.geothermal_loops[0].num_bore_holes = nil hpxml_bldg.geothermal_loops[0].bore_config = HPXML::GeothermalLoopBorefieldConfigurationRectangle XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path) _default_hpxml, default_hpxml_bldg = _test_measure() - _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 0.75, 2.0161, HPXML::GeothermalLoopBorefieldConfigurationRectangle) + _test_default_geothermal_loop_values(default_hpxml_bldg.geothermal_loops[0], HPXML::GeothermalLoopLoopConfigurationVertical, nil, nil, 16.4, nil, 5.0, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.8, HPXML::GeothermalLoopGroutOrPipeTypeThermallyEnhanced, 0.40, 1.25, 2.6261, HPXML::GeothermalLoopBorefieldConfigurationRectangle) end def test_hvac_location diff --git a/docs/source/workflow_inputs.rst b/docs/source/workflow_inputs.rst index 20f8acbd4f..de74310b09 100644 --- a/docs/source/workflow_inputs.rst +++ b/docs/source/workflow_inputs.rst @@ -2290,7 +2290,7 @@ Each geothermal loop is entered as an ``/HPXML/Building/BuildingDetails/Systems/ ``BoreholesOrTrenches/Diameter`` double in > 0 No 5.0 ``Grout/Type`` or ``Grout/Conductivity`` string or double Btu/hr-ft-F See [#]_ or > 0 No standard Grout type or conductivity [#]_ ``Pipe/Type`` or ``Pipe/Conductivity`` string or double Btu/hr-ft-F See [#]_ or > 0 No standard Pipe type or conductivity [#]_ - ``Pipe/Diameter`` double in See [#]_ No 0.75 + ``Pipe/Diameter`` double in See [#]_ No 1.25 ``Pipe/ShankSpacing`` double in > 0 No See [#]_ Center-to-center distance between two branches of a vertical U-tube ``extension/BorefieldConfiguration`` string See [#]_ No Rectangle ======================================== ================ =========== =============== ======== ============== ===============================================