Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output data from SimpleSolar and SolarPySAM consistent #126

Open
misi9170 opened this issue Nov 22, 2024 · 0 comments · May be fixed by #127
Open

Make output data from SimpleSolar and SolarPySAM consistent #126

misi9170 opened this issue Nov 22, 2024 · 0 comments · May be fixed by #127

Comments

@misi9170
Copy link
Collaborator

The return_outputs() methods of SimpleSolar and SolarPySAM both (correctly) return dictionaries, but they aren't consistent, which means that the two solar modules can't be exchanged directly. Currently, the return dictionary from SolarPySAM has keys "power_mw", "dni", and "aoi", whereas the SimpleSolar return dictionary contains "power" and "irradiance".

We should make these consistent (even if they hold null values in the SimpleSolar case) so that the modules can be readily interchanged.

@genevievestarke genevievestarke linked a pull request Nov 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant