From a264ead78c88a148643ea30cc511de91f7d6b6bf Mon Sep 17 00:00:00 2001 From: Jun Aishima Date: Wed, 12 Feb 2025 13:52:54 -0500 Subject: [PATCH] use correct proposal_type_id for the facility specified * remove hard-coded NSLS-II commissioning proposal type ID --- src/nsls2api/services/pass_service.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/nsls2api/services/pass_service.py b/src/nsls2api/services/pass_service.py index 747659a..fccbf5c 100644 --- a/src/nsls2api/services/pass_service.py +++ b/src/nsls2api/services/pass_service.py @@ -149,9 +149,8 @@ async def get_commissioning_proposals_by_year( error_message: str = f"Facility {facility_name} does not have a PASS ID." logger.error(error_message) raise PassException(error_message) - - # The PASS ID for commissioning proposals is 300005 - url = f"{base_url}/Proposal/GetProposalsByType/{api_key}/{pass_facility}/{year}/300005/NULL" + pass_commissioning_type = await get_commissioning_proposal_type(facility_name) + url = f"{base_url}/Proposal/GetProposalsByType/{api_key}/{pass_facility}/{year}/{pass_commissioning_type.pass_id}/NULL" try: pass_commissioning_proposals = await _call_pass_webservice(url)