Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python kernel builder uses empty strings for measurement names #2538

Closed
schweitzpgi opened this issue Jan 24, 2025 · 0 comments · Fixed by #2588
Closed

Python kernel builder uses empty strings for measurement names #2538

schweitzpgi opened this issue Jan 24, 2025 · 0 comments · Fixed by #2588
Assignees
@schweitzpgi
Labels
bug Something isn't working python bridge Involves the python bridge to quake

Comments

@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Jan 24, 2025 •
edited
Loading

The following operation is invalid.

   quake.mz %1 name "" : (!quake.ref) -> i1    // this is going to be made illegal

because the name is empty. The python kernel builder needs to be updated to avoid generating these.
@schweitzpgi schweitzpgi added bug Something isn't working python bridge Involves the python bridge to quake labels Jan 24, 2025
@schweitzpgi schweitzpgi self-assigned this Feb 1, 2025
schweitzpgi added a commit to schweitzpgi/cuda-quantum that referenced this issue Feb 5, 2025
@schweitzpgi
Remove the python hooks to the old codegen. This exposes all the
094f9cb 
python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of
quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix NVIDIA#2538 - measurement register name cannot be empty.

Signed-off-by: Eric Schweitz <[email protected]>
@schweitzpgi schweitzpgi mentioned this issue Feb 5, 2025
Closed
schweitzpgi added a commit to schweitzpgi/cuda-quantum that referenced this issue Feb 5, 2025
@schweitzpgi
Remove the python hooks to the old codegen. This exposes all the
2acc144 
python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of
quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix NVIDIA#2538 - measurement register name cannot be empty.

Signed-off-by: Eric Schweitz <[email protected]>
schweitzpgi added a commit to schweitzpgi/cuda-quantum that referenced this issue Feb 5, 2025
@schweitzpgi
Remove the python hooks to the old codegen. This exposes all the
2969d93 
python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of
quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix NVIDIA#2538 - measurement register name cannot be empty.

Signed-off-by: Eric Schweitz <[email protected]>
@schweitzpgi schweitzpgi mentioned this issue Feb 6, 2025
Merged
schweitzpgi added a commit to schweitzpgi/cuda-quantum that referenced this issue Feb 6, 2025
@schweitzpgi
Remove the python hooks to the old codegen. This exposes all the
473ec45 
python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of
quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix NVIDIA#2538 - measurement register name cannot be empty.

Signed-off-by: Eric Schweitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schweitzpgi schweitzpgi

Labels
bug Something isn't working python bridge Involves the python bridge to quake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] enable the new QIR codegen for python schweitzpgi/cuda-quantum
1 participant
@schweitzpgi