Merge pull request #122 from shivamerla/fix_cr_deletions

Don't ignore update events on CRs when the object is marked for deletion

Author: ArangoGutierrez

internal/controller/nimcache_controller.go

@@ -209,6 +209,11 @@ func (r *NIMCacheReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				if oldNIMCache, ok := e.ObjectOld.(*appsv1alpha1.NIMCache); ok {
 					newNIMCache := e.ObjectNew.(*appsv1alpha1.NIMCache)
 
+					// Handle case where object is marked for deletion
+					if !newNIMCache.ObjectMeta.DeletionTimestamp.IsZero() {
+						return true
+					}
+
 					// Handle only spec updates
 					return !reflect.DeepEqual(oldNIMCache.Spec, newNIMCache.Spec)
 				}

internal/controller/nimpipeline_controller.go

@@ -367,6 +367,11 @@ func (r *NIMPipelineReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				if oldNIMPipeline, ok := e.ObjectOld.(*appsv1alpha1.NIMPipeline); ok {
 					newNIMPipeline := e.ObjectNew.(*appsv1alpha1.NIMPipeline)
 
+					// Handle case where object is marked for deletion
+					if !newNIMPipeline.ObjectMeta.DeletionTimestamp.IsZero() {
+						return true
+					}
+
 					// Handle only spec updates
 					return !reflect.DeepEqual(oldNIMPipeline.Spec, newNIMPipeline.Spec)
 				}

internal/controller/nimservice_controller.go

@@ -194,6 +194,11 @@ func (r *NIMServiceReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				if oldNIMService, ok := e.ObjectOld.(*appsv1alpha1.NIMService); ok {
 					newNIMService := e.ObjectNew.(*appsv1alpha1.NIMService)
 
+					// Handle case where object is marked for deletion
+					if !newNIMService.ObjectMeta.DeletionTimestamp.IsZero() {
+						return true
+					}
+
 					// Handle only spec updates
 					return !reflect.DeepEqual(oldNIMService.Spec, newNIMService.Spec)
 				}