Skip to content

Commit bfe8ea0

Browse files
committed
Fixing nitpicks
Signed-off-by: Shiva Krishna, Merla <[email protected]>
1 parent 31bc049 commit bfe8ea0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

internal/controller/nemocustomizer_controller.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -511,15 +511,15 @@ func (r *NemoCustomizerReconciler) renderCustomizerConfig(ctx context.Context, n
511511
return nil, err
512512
}
513513

514-
if err := r.addModelConfig(ctx, cfg, n); err != nil {
514+
if err := r.addModelConfig(ctx, n, cfg); err != nil {
515515
return nil, err
516516
}
517517

518-
if err := r.addCustomizationTargetConfig(ctx, cfg, n); err != nil {
518+
if err := r.addCustomizationTargetConfig(ctx, n, cfg); err != nil {
519519
return nil, err
520520
}
521521

522-
if err := r.addCustomizationConfigTemplates(ctx, cfg, n); err != nil {
522+
if err := r.addCustomizationConfigTemplates(ctx, n, cfg); err != nil {
523523
return nil, err
524524
}
525525

@@ -700,7 +700,7 @@ func (r *NemoCustomizerReconciler) addTrainingConfig(ctx context.Context, cfg ma
700700
return nil
701701
}
702702

703-
func (r *NemoCustomizerReconciler) addModelConfig(ctx context.Context, cfg map[string]interface{}, n *appsv1alpha1.NemoCustomizer) error {
703+
func (r *NemoCustomizerReconciler) addModelConfig(ctx context.Context, n *appsv1alpha1.NemoCustomizer, cfg map[string]interface{}) error {
704704
modelsRaw, err := k8sutil.GetRawYAMLFromConfigMap(ctx, r.GetClient(), n.GetNamespace(), n.Spec.Models.Name, "models")
705705
if err != nil {
706706
if goerrors.Is(err, k8sutil.ErrConfigMapKeyNotFound) {
@@ -719,7 +719,7 @@ func (r *NemoCustomizerReconciler) addModelConfig(ctx context.Context, cfg map[s
719719
return nil
720720
}
721721

722-
func (r *NemoCustomizerReconciler) addCustomizationTargetConfig(ctx context.Context, cfg map[string]interface{}, n *appsv1alpha1.NemoCustomizer) error {
722+
func (r *NemoCustomizerReconciler) addCustomizationTargetConfig(ctx context.Context, n *appsv1alpha1.NemoCustomizer, cfg map[string]interface{}) error {
723723
customizationTargetsRaw, err := k8sutil.GetRawYAMLFromConfigMap(ctx, r.GetClient(), n.GetNamespace(), n.Spec.Models.Name, "customizationTargets")
724724
if err != nil {
725725
if goerrors.Is(err, k8sutil.ErrConfigMapKeyNotFound) {
@@ -738,7 +738,7 @@ func (r *NemoCustomizerReconciler) addCustomizationTargetConfig(ctx context.Cont
738738
return nil
739739
}
740740

741-
func (r *NemoCustomizerReconciler) addCustomizationConfigTemplates(ctx context.Context, cfg map[string]interface{}, n *appsv1alpha1.NemoCustomizer) error {
741+
func (r *NemoCustomizerReconciler) addCustomizationConfigTemplates(ctx context.Context, n *appsv1alpha1.NemoCustomizer, cfg map[string]interface{}) error {
742742
customizationConfigTemplatesRaw, err := k8sutil.GetRawYAMLFromConfigMap(ctx, r.GetClient(), n.GetNamespace(), n.Spec.Models.Name, "customizationConfigTemplates")
743743
if err != nil {
744744
if goerrors.Is(err, k8sutil.ErrConfigMapKeyNotFound) {

0 commit comments

Comments
 (0)