Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphCast: Add the option to use transformer_engine.LayerNorm #516

Closed
Tracked by #499
mnabian opened this issue May 21, 2024 · 1 comment
Closed
Tracked by #499

GraphCast: Add the option to use transformer_engine.LayerNorm #516

mnabian opened this issue May 21, 2024 · 1 comment
Assignees
@mnabian

Comments

@mnabian
Copy link
Collaborator

mnabian commented May 21, 2024 •
edited
Loading

Note from Max: Can we add the option to use transformer_engine.LayerNorm? In AIFS benchmarks, we just could get a 1.3x end-to-end improvement from doing so since the PyTorch implementation is rather bad for the sizes we encounter in these workloads.
@mnabian mnabian mentioned this issue May 21, 2024
Closed
@mnabian mnabian self-assigned this May 21, 2024
@mnabian mnabian mentioned this issue May 21, 2024
Merged
5 tasks
@mnabian
Copy link
Collaborator Author

mnabian commented May 22, 2024

#510

@mnabian mnabian closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnabian mnabian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnabian