Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG]: MeshGraphNet tests fail if default norm is TELayerNorm #794

Open
coreyjadams opened this issue Feb 13, 2025 · 1 comment
Open
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@coreyjadams
Copy link
Collaborator

Version

0.10.0

On which installation method(s) does this occur?

No response

Describe the issue

MeshGraphNet is approximately 2x faster in some scenarios using TELayerNorm instead of LayerNorm. TELayerNorm is not available for CPU.

In the pending PR #787 , MeshGraphNet will catch and replace with LayerNorm if cuda is not available. But for the tests, cuda is available on the CPU tests, just not used.

To fix this issue, we need to update the tests to use LayerNorm on cpu devices.

Minimum reproducible example

Relevant log output

Environment details

@coreyjadams coreyjadams added ? - Needs Triage Need team to review and classify bug Something isn't working labels Feb 13, 2025
@coreyjadams coreyjadams self-assigned this Feb 13, 2025
@coreyjadams
Copy link
Collaborator Author

FYI @mnabian @ktangsali I plan to make these changes after the RC candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant