Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀[FEA]: Allow passing models as to EDMPrecond #796

Open
simonbyrne opened this issue Feb 17, 2025 · 0 comments
Open

🚀[FEA]: Allow passing models as to EDMPrecond #796

simonbyrne opened this issue Feb 17, 2025 · 0 comments
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request

Comments

@simonbyrne
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Currently models are passed as names (strings) and splatted arguments. This makes it confusing to determine which arguments get passed to the model and which go to the preconditioner. It would be nice to also allow just passing an initialized model itself. The downside is that the user would be required to determine the correct input and output channels, but I don't think this is too onerous (and it could also be checked when the preconditioner is initialized.

Describe any alternatives you have considered

No response

@simonbyrne simonbyrne added ? - Needs Triage Need team to review and classify enhancement New feature or request labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant