Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos in observations and in forecast do not enlarge correctly when clicked on in iPad #892

Open
rustynwac opened this issue Feb 19, 2025 · 7 comments

Comments

@rustynwac
Copy link

IPadOS 18.2.1 (22C161)

Image

Will updates to media types (Spring 2024/25) change anything here?

@stevekuznetsov
Copy link
Collaborator

If we entirely overhaul the carousel, maybe. Otherwise, no. If we want to support tablets explicitly we should pay attention to that overall. We haven't been doing that in the past.

@kevinherdez
Copy link

For context, this is being handled completely by an external package right now. As a part of adding video support, we could try to make this better, but as Steve said it would probably require us creating a completely custom carousel unless we can find some image viewing package that would already handle this. I'll keep it in mind as I keep going on adding support for the different types.

@kevinherdez
Copy link

@rustynwac, just to confirm, are the repro steps for this just opening the image carousel on an iPad while it's in landscape, or did you hit this after zooming in on the image or something? I want to address this issue with the changes I'm making to the carousel, and I just want to make sure I'm not missing something in my testing

@rustynwac
Copy link
Author

@kevinherdez I don't have an iPad to test on. It was a user submitted issue. We don't need to prioritize tablets though so don't worry about spending too much time on it.

@stevekuznetsov
Copy link
Collaborator

@kevinherdez if you do have a chance, though - it would be awesome to tackle #578

@kevinherdez
Copy link

I just tested and that bug should be fixed with the new carousel!

@kevinherdez
Copy link

@kevinherdez I don't have an iPad to test on. It was a user submitted issue. We don't need to prioritize tablets though so don't worry about spending too much time on it.

Sounds good. At the very least I'm hoping that it's at least a better than what's currently there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants