Merge pull request #78 from NatLibFi/simplifyTypeOfMaterialRules

Simplify type of material rules

Author: nvolk

package-lock.json

@@ -213,59 +213,27 @@ export class MarcRecord {
   }
 
   isCF() {
-    if (this.getTypeOfRecord() !== 'm') {
-      return false;
-    }
-    if (!this._bibliographicLevelIsBis()) {
-      return true;
-    }
-
-    return this._containsField006FormOfMaterialS();
+    return this.getTypeOfRecord() === 'm';
   }
 
   isCR() {
     return ['a', 't'].includes(this.getTypeOfRecord()) && this._bibliographicLevelIsBis();
   }
 
   isMP() {
-    if (!['e', 'f'].includes(this.getTypeOfRecord())) {
-      return false;
-    }
-    if (!this._bibliographicLevelIsBis()) {
-      return true;
-    }
-    return this._containsField006FormOfMaterialS();
+    return ['e', 'f'].includes(this.getTypeOfRecord());
   }
 
   isMU() {
-    if (!['c', 'd', 'i', 'j'].includes(this.getTypeOfRecord())) {
-      return false;
-    }
-    if (!this._bibliographicLevelIsBis()) {
-      return true;
-    }
-    return this._containsField006FormOfMaterialS();
+    return ['c', 'd', 'i', 'j'].includes(this.getTypeOfRecord());
   }
 
   isMX() {
-    if (this.getTypeOfRecord() !== 'p') {
-      return false;
-    }
-    if (!this._bibliographicLevelIsBis(this)) {
-      return true;
-    }
-    return this._containsField006FormOfMaterialS();
+    return this.getTypeOfRecord() === 'p';
   }
 
   isVM() {
-    if (!['g', 'k', 'o', 'r'].includes(this.getTypeOfRecord())) {
-      return false;
-    }
-
-    if (!this._bibliographicLevelIsBis()) {
-      return true;
-    }
-    return this._containsField006FormOfMaterialS();
+    return ['g', 'k', 'o', 'r'].includes(this.getTypeOfRecord());
   }
 
   getTypeOfMaterial() {
@@ -297,11 +265,6 @@ export class MarcRecord {
     return ['b', 'i', 's'].includes(this.getBibliograpicLevel());
   }
 
-  _containsField006FormOfMaterialS() {
-    const fields006 = this.get('006');
-    return fields006.some(field => field.value[0] === 's');
-  }
-
   equalsTo(record) {
     return MarcRecord.isEqual(this, record);
   }

src/index.js

@@ -1,8 +1,8 @@
 {
-  "description": "fail to determine the type of material (LDR/07+006/00 combo)",
+  "description": "fail to determine the type of material (Illegal LDR/06)",
   "skip": false,
   "input": {
-    "leader": "01234cki a22005894i 4500",
+    "leader": "01234cbi a22005894i 4500",
     "fields":
     [
       {"tag": "001", "value": "bar"},