Skip to content

Commit 4a408e3

Browse files
committed
chore: nx migrate latest
1 parent 91557e8 commit 4a408e3

24 files changed

+2178
-1555
lines changed

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"root": true,
3-
"ignorePatterns": ["**/*"],
3+
"ignorePatterns": ["**/*", "dist/**/*"],
44
"plugins": ["@nx"],
55
"overrides": [
66
{

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ jobs:
2525
node-version: lts/*
2626
- uses: nrwl/nx-set-shas@v3
2727
- name: npm install
28-
run: npm install --legacy-peer-deps
28+
run: npm install
2929
- name: Build.all affected
3030
run: npx nx affected --target=build --exclude nativescript-demo-ng

apps/nativescript-demo-ng/src/app/app.component.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
1-
import { Component, NO_ERRORS_SCHEMA, OnDestroy, OnInit, ViewContainerRef } from '@angular/core';
1+
import { Component, NO_ERRORS_SCHEMA, OnDestroy, OnInit } from '@angular/core';
22
import { PageRouterOutlet } from '@nativescript/angular';
33

44
// registerElement('ns-app', () => GridLayout);
55
@Component({
66
selector: 'ns-app',
7-
moduleId: module.id,
87
templateUrl: './app.component.html',
98
imports: [PageRouterOutlet],
109
schemas: [NO_ERRORS_SCHEMA],
1110
})
1211
export class AppComponent implements OnInit, OnDestroy {
13-
constructor(private vcRef: ViewContainerRef) {}
12+
1413
ngOnInit() {
1514
console.log('ngOnInit');
1615
}

apps/nativescript-demo-ng/src/app/home/home.component.ts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,27 @@
1-
import { Component, NgZone, OnInit } from '@angular/core';
1+
import { Component, inject, NgZone, NO_ERRORS_SCHEMA, OnInit } from '@angular/core';
22
import { ActivatedRoute, Router } from '@angular/router';
33
import { RouterExtensions, NativeScriptCommonModule } from '@nativescript/angular';
44
import { Page, TabView } from '@nativescript/core';
55

66
@Component({
7-
moduleId: module.id,
87
selector: 'demo-home',
98
templateUrl: './home.component.html',
109
imports: [NativeScriptCommonModule],
11-
standalone: true,
10+
schemas: [NO_ERRORS_SCHEMA]
1211
})
1312
export class HomeComponent implements OnInit {
13+
private _ngZone = inject(NgZone);
14+
// vcRef: ViewContainerRef,
15+
private _activeRoute = inject(ActivatedRoute);
16+
private _page = inject(Page);
17+
private _ngRouter = inject(Router);
18+
private _router = inject(RouterExtensions);
1419
tabItems: { [key: string]: { index: number; title?: string; iconSource?: string; textTransform?: string } } = {};
1520
private _tabs = ['start'];
1621
private _hasInitTab: { start?: boolean } = {};
1722
private _tabView: TabView;
1823

19-
constructor(
20-
private _ngZone: NgZone,
21-
// vcRef: ViewContainerRef,
22-
private _activeRoute: ActivatedRoute,
23-
private _page: Page,
24-
private _ngRouter: Router,
25-
private _router: RouterExtensions,
26-
) {
24+
constructor() {
2725
this._initMenu();
2826
}
2927

apps/nativescript-demo-ng/src/app/item/item-detail.component.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, NO_ERRORS_SCHEMA, OnInit } from '@angular/core';
1+
import { Component, inject, NO_ERRORS_SCHEMA, OnInit } from '@angular/core';
22
import { ActivatedRoute } from '@angular/router';
33

44
import { Item } from './item';
@@ -7,19 +7,14 @@ import { NativeScriptCommonModule } from '@nativescript/angular';
77

88
@Component({
99
selector: 'ns-details',
10-
moduleId: module.id,
1110
templateUrl: './item-detail.component.html',
1211
imports: [NativeScriptCommonModule],
13-
standalone: true,
14-
schemas: [NO_ERRORS_SCHEMA]
12+
schemas: [NO_ERRORS_SCHEMA],
1513
})
1614
export class ItemDetailComponent implements OnInit {
1715
item: Item;
18-
19-
constructor(
20-
private itemService: ItemService,
21-
private route: ActivatedRoute,
22-
) {}
16+
private itemService = inject(ItemService);
17+
private route = inject(ActivatedRoute);
2318

2419
ngOnInit(): void {
2520
const id = +this.route.snapshot.params.id;

apps/nativescript-demo-ng/src/app/item/items.component.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA } from '@angular/core';
1+
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA, inject } from '@angular/core';
22
import { HttpClient } from '@angular/common/http';
33

44
import { Item } from './item';
@@ -8,22 +8,17 @@ import { ModalDialogService, NativeDialogService, NativeScriptCommonModule } fro
88

99
@Component({
1010
selector: 'ns-items',
11-
moduleId: module.id,
1211
templateUrl: './items.component.html',
1312
imports: [NativeScriptCommonModule],
14-
standalone: true,
1513
schemas: [NO_ERRORS_SCHEMA],
1614
})
1715
export class ItemsComponent implements OnInit, OnDestroy {
1816
message = 'Hello Angular 20.0.0!';
1917
items: Array<Item>;
20-
21-
constructor(
22-
private itemService: ItemService,
23-
private nativeDialog: NativeDialogService,
24-
private modalDialog: ModalDialogService,
25-
private http: HttpClient,
26-
) {}
18+
private itemService = inject(ItemService);
19+
private nativeDialog = inject(NativeDialogService);
20+
private modalDialog = inject(ModalDialogService);
21+
private http = inject(HttpClient);
2722

2823
ngOnInit(): void {
2924
console.log('ItemsComponent ngOnInit');

apps/nativescript-demo-ng/src/app/item2/item-detail2.component.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA } from '@angular/core';
1+
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA, inject } from '@angular/core';
22
import { ActivatedRoute } from '@angular/router';
33
import { NativeScriptCommonModule, RouterExtensions } from '@nativescript/angular';
44

@@ -7,20 +7,17 @@ import { ItemService } from '../item/item.service';
77

88
@Component({
99
selector: 'ns-details2',
10-
moduleId: module.id,
1110
templateUrl: './item-detail2.component.html',
1211
imports: [NativeScriptCommonModule],
13-
standalone: true,
14-
schemas: [NO_ERRORS_SCHEMA]
12+
schemas: [NO_ERRORS_SCHEMA],
1513
})
1614
export class ItemDetailComponent implements OnInit, OnDestroy {
15+
private itemService = inject(ItemService);
16+
private route = inject(ActivatedRoute);
17+
private router = inject(RouterExtensions);
1718
item: Item;
1819

19-
constructor(
20-
private itemService: ItemService,
21-
private route: ActivatedRoute,
22-
private router: RouterExtensions,
23-
) {
20+
constructor() {
2421
console.log('ItemDetail2Component construct');
2522
}
2623

apps/nativescript-demo-ng/src/app/item3/items.component.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA } from '@angular/core';
1+
import { Component, OnInit, OnDestroy, NO_ERRORS_SCHEMA, inject } from '@angular/core';
22
import { HttpClient } from '@angular/common/http';
33

44
import { Item } from '../item/item';
@@ -13,24 +13,21 @@ import {
1313

1414
@Component({
1515
selector: 'ns-items',
16-
moduleId: module.id,
1716
templateUrl: './items.component.html',
1817
imports: [NativeScriptCommonModule, NativeScriptRouterModule],
19-
standalone: true,
2018
schemas: [NO_ERRORS_SCHEMA],
2119
})
2220
export class ItemsComponent implements OnInit, OnDestroy {
21+
private itemService = inject(ItemService);
22+
private nativeDialog = inject(NativeDialogService);
23+
private modalDialog = inject(ModalDialogService);
24+
private http = inject(HttpClient);
2325
message = 'Hello Angular 20.0.0';
2426
items: Array<Item>;
2527
borderRadius: number;
2628
fontSize: number;
2729

28-
constructor(
29-
private itemService: ItemService,
30-
private nativeDialog: NativeDialogService,
31-
private modalDialog: ModalDialogService,
32-
private http: HttpClient,
33-
) {
30+
constructor() {
3431
if (global.isAndroid) {
3532
this.borderRadius = 25;
3633
this.fontSize = 15;

apps/nativescript-demo-ng/src/app/modal/modal.component.ts

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,31 @@
11
import { Component, NO_ERRORS_SCHEMA, OnDestroy, OnInit, Optional, ViewContainerRef, inject } from '@angular/core';
2-
import { ModalDialogService, NativeDialogModule, NativeDialogRef, NativeDialogService, NativeScriptCommonModule } from '@nativescript/angular';
2+
import {
3+
ModalDialogService,
4+
NativeDialogModule,
5+
NativeDialogRef,
6+
NativeDialogService,
7+
NativeScriptCommonModule,
8+
} from '@nativescript/angular';
39
import { ItemService } from '../item/item.service';
410
import { View } from '@nativescript/core';
511

612
@Component({
713
selector: 'ns-modal',
814
templateUrl: `./modal.component.html`,
915
imports: [NativeScriptCommonModule, NativeDialogModule],
10-
standalone: true,
11-
schemas: [NO_ERRORS_SCHEMA]
16+
schemas: [NO_ERRORS_SCHEMA],
1217
})
1318
export class ModalComponent implements OnInit, OnDestroy {
19+
private ref = inject(NativeDialogRef<ModalComponent>, { optional: true });
20+
private nativeDialog = inject(NativeDialogService);
21+
private modalDialog = inject(ModalDialogService);
22+
private vcRef = inject(ViewContainerRef);
1423
id = Math.floor(Math.random() * 1000);
1524
itemService = inject(ItemService);
1625
logo: string;
1726
color: string;
1827

19-
constructor(
20-
@Optional() private ref: NativeDialogRef<ModalComponent>,
21-
private nativeDialog: NativeDialogService,
22-
private modalDialog: ModalDialogService,
23-
private vcRef: ViewContainerRef,
24-
) {
28+
constructor() {
2529
this.logo = this.itemService.flavors[this.itemService.currentFlavor].logo;
2630
this.color = this.itemService.flavors[this.itemService.currentFlavor].color;
2731
}

apps/nativescript-demo-ng/src/tests/detached-utils-tests.spec.ts

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,17 @@
1-
import { Component, ComponentFactory, ComponentFactoryResolver, ComponentRef, EmbeddedViewRef, Injector, NgModule, NO_ERRORS_SCHEMA, TemplateRef, ViewChild, ViewContainerRef } from '@angular/core';
1+
import {
2+
Component,
3+
ComponentFactory,
4+
ComponentFactoryResolver,
5+
ComponentRef,
6+
EmbeddedViewRef,
7+
inject,
8+
Injector,
9+
NgModule,
10+
NO_ERRORS_SCHEMA,
11+
TemplateRef,
12+
ViewChild,
13+
ViewContainerRef,
14+
} from '@angular/core';
215
import { ComponentFixture, TestBed } from '@angular/core/testing';
316
import { generateDetachedLoader, generateNativeScriptView, NgViewRef } from '@nativescript/angular';
417
import { GridLayout, ProxyViewContainer } from '@nativescript/core';
@@ -10,7 +23,7 @@ import { GridLayout, ProxyViewContainer } from '@nativescript/core';
1023
export class GenerateViewComponent {
1124
@ViewChild('vc', { read: ViewContainerRef }) vc: ViewContainerRef;
1225
@ViewChild('template', { read: TemplateRef }) template: TemplateRef<void>;
13-
constructor(public injector: Injector) {}
26+
injector = inject(Injector);
1427
}
1528

1629
@Component({
@@ -67,7 +80,10 @@ describe('generateNativeScriptView', () => {
6780
});
6881

6982
it('should reuse a DetachedLoaderRef', () => {
70-
const containerRef = generateDetachedLoader(fixture.componentRef.instance.injector.get(ComponentFactoryResolver), fixture.componentRef.instance.injector);
83+
const containerRef = generateDetachedLoader(
84+
fixture.componentRef.instance.injector.get(ComponentFactoryResolver),
85+
fixture.componentRef.instance.injector,
86+
);
7187
cleanup.push(containerRef);
7288
const ngViewRef = generateNativeScriptView(GeneratedComponent, {
7389
injector: fixture.componentRef.instance.injector,

0 commit comments

Comments
 (0)