Skip to content

Commit 1090095

Browse files
committed
fix: revert changes to modal navigation e2e
1 parent 1d640af commit 1090095

File tree

8 files changed

+21
-14
lines changed

8 files changed

+21
-14
lines changed

e2e/modal-navigation-ng/app/app.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { Component, ViewContainerRef } from "@angular/core";
22
import { Router, NavigationEnd } from "@angular/router";
3-
// import { NSLocationStrategy } from "nativescript-angular/router/ns-location-strategy";
3+
import { NSLocationStrategy } from "nativescript-angular/router/ns-location-strategy";
44

55
import { ViewContainerRefService } from "./shared/ViewContainerRefService";
66

77
import { AppModule } from "./app.module";
8-
import { ModalDialogOptions, ModalDialogService, NSLocationStrategy } from "nativescript-angular";
8+
import { ModalDialogOptions, ModalDialogService } from "nativescript-angular";
99
import { ModalViewComponent } from "./modal-shared/modal-view.component";
1010

1111
@Component({

e2e/modal-navigation-ng/app/app.module.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ import { ModalSharedSecondComponent } from "./modal-shared/modal-shared-second.c
2020
import { ViewContainerRefService } from "./shared/ViewContainerRefService";
2121

2222
import { enable as traceEnable, addCategories } from "tns-core-modules/trace";
23-
import { NativeScriptPlatformRef, routerTraceCategory } from "nativescript-angular";
23+
import { routerTraceCategory } from "nativescript-angular/trace";
24+
import { NativeScriptPlatformRef } from "nativescript-angular";
2425

2526
addCategories(routerTraceCategory);
2627
traceEnable();

e2e/modal-navigation-ng/app/home/home.component.ts

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
import { Component, ViewContainerRef } from "@angular/core";
2-
import { ModalDialogService, RouterExtensions } from "nativescript-angular";
2+
import { ModalDialogService, ModalDialogOptions } from "nativescript-angular/directives/dialogs";
3+
import { RouterExtensions } from "nativescript-angular/router";
4+
import { EventData } from "tns-core-modules/data/observable";
5+
36
import { ViewContainerRefService } from "../shared/ViewContainerRefService";
7+
import { ModalRouterComponent } from "../modal/modal-router/modal-router.component";
8+
import { ModalComponent } from "../modal/modal.component";
9+
import { ModalViewComponent } from "../modal-shared/modal-view.component";
10+
import { confirm } from "tns-core-modules/ui/dialogs";
11+
12+
import { AppModule } from "../app.module";
413

514
@Component({
615
moduleId: module.id,

e2e/modal-navigation-ng/app/layout.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Component, ViewContainerRef } from "@angular/core";
22
import { Router, NavigationEnd } from "@angular/router";
3-
import { NSLocationStrategy } from "nativescript-angular/router";
3+
import { NSLocationStrategy } from "nativescript-angular/router/ns-location-strategy";
44
import { ModalDialogService, ModalDialogOptions } from "nativescript-angular/directives/dialogs";
55
import { ModalViewComponent } from "./modal-shared/modal-view.component";
66
import { ViewContainerRefService } from "./shared/ViewContainerRefService";

e2e/modal-navigation-ng/app/main.aot.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// this import should be first in order to load some required settings (like globals and reflect-metadata)
2-
import { platformNativeScript } from "nativescript-angular";
3-
console.log(">>>>>>>>main.aot.ts");
4-
2+
import { platformNativeScript } from "nativescript-angular/platform-static";
53
import { AppModule } from "./app.module";
64
import { NativeScriptPlatformRef } from "nativescript-angular";
75
// "./app.module.ngfactory" is a dynamically generated module when compiled with AoT.

e2e/modal-navigation-ng/app/main.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// this import should be first in order to load some required settings (like globals and reflect-metadata)
2-
import { platformNativeScriptDynamic } from "nativescript-angular";
3-
console.log(">>>>>>>>main.ts");
2+
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
43

54
import { AppModule } from "./app.module";
65
import { NativeScriptPlatformRef } from "nativescript-angular";

e2e/modal-navigation-ng/app/named-router.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Component, ViewContainerRef } from "@angular/core";
22
import { Router, NavigationEnd } from "@angular/router";
3-
import { NSLocationStrategy } from "nativescript-angular";
3+
import { NSLocationStrategy } from "nativescript-angular/router/ns-location-strategy";
44

55
import { ViewContainerRefService } from "./shared/ViewContainerRefService";
66
import { AppModule } from "./app.module";

e2e/modal-navigation-ng/app/tab.component.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Component, ViewContainerRef } from "@angular/core";
22
import { Router, NavigationEnd } from "@angular/router";
3-
// import { NSLocationStrategy } from "nativescript-angular";
3+
import { NSLocationStrategy } from "nativescript-angular/router/ns-location-strategy";
44

55
import { ViewContainerRefService } from "./shared/ViewContainerRefService";
66
import { AppModule } from "./app.module";
@@ -14,14 +14,14 @@ import { ModalViewComponent } from "./modal-shared/modal-view.component";
1414
export class TabComponent {
1515
constructor(
1616
router: Router,
17-
// location: NSLocationStrategy,
17+
location: NSLocationStrategy,
1818
private _vcRef: ViewContainerRef,
1919
private _viewContainerRefService: ViewContainerRefService,
2020
private modal: ModalDialogService) {
2121
router.events.subscribe(e => {
2222
if (e instanceof NavigationEnd) {
2323
console.log("[ROUTER]: " + e.toString());
24-
// console.log(location.toString());
24+
console.log(location.toString());
2525
}
2626
});
2727

0 commit comments

Comments
 (0)