Skip to content

Commit 8c996fd

Browse files
Plugin causes Angular apps to crash #42
1 parent 27b4247 commit 8c996fd

File tree

7 files changed

+45
-40
lines changed

7 files changed

+45
-40
lines changed

Diff for: demo-ng/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
"nativescript": {
33
"id": "org.nativescript.demong.AppSync",
44
"tns-android": {
5-
"version": "6.0.2"
5+
"version": "6.1.2"
66
},
77
"tns-ios": {
8-
"version": "6.0.2"
8+
"version": "6.1.0"
99
}
1010
},
1111
"description": "NativeScript Application",
@@ -43,17 +43,17 @@
4343
"@angular/platform-browser-dynamic": "~8.2.3",
4444
"@angular/router": "~8.2.3",
4545
"nativescript-angular": "~8.2.0",
46-
"nativescript-app-sync": "file:../publish/package/nativescript-app-sync-1.0.6.tgz",
46+
"nativescript-app-sync": "file:../publish/package/nativescript-app-sync-1.0.7.tgz",
4747
"nativescript-theme-core": "~1.0.6",
4848
"reflect-metadata": "~0.1.13",
4949
"rxjs": "~6.5.2",
50-
"tns-core-modules": "~6.0.7",
50+
"tns-core-modules": "~6.1.0",
5151
"zone.js": "~0.10.0"
5252
},
5353
"devDependencies": {
5454
"@angular/compiler-cli": "~8.2.3",
5555
"@ngtools/webpack": "~8.2.2",
56-
"nativescript-dev-webpack": "~1.1.1",
56+
"nativescript-dev-webpack": "~1.2.0",
5757
"typescript": "3.4.5"
5858
}
5959
}

Diff for: demo-ng/src/app/app.component.ts

+2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ export class AppComponent {
4242
console.log("AppSync: up to date");
4343
} else if (syncStatus === SyncStatus.UPDATE_INSTALLED) {
4444
console.log("AppSync: update installed");
45+
} else {
46+
console.log("AppSync: sync status: " + syncStatus);
4547
}
4648
});
4749
}

Diff for: demo-ng/tsconfig.json

+28-24
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,29 @@
11
{
2-
"compilerOptions": {
3-
"module": "commonjs",
4-
"target": "es5",
5-
"experimentalDecorators": true,
6-
"emitDecoratorMetadata": true,
7-
"noEmitHelpers": true,
8-
"noEmitOnError": true,
9-
"lib": [
10-
"es6",
11-
"dom",
12-
"es2015.iterable"
13-
],
14-
"baseUrl": ".",
15-
"paths": {
16-
"~/*": [
17-
"src/*"
18-
]
19-
}
20-
},
21-
"exclude": [
22-
"node_modules",
23-
"platforms"
24-
]
25-
}
2+
"compilerOptions": {
3+
"module": "commonjs",
4+
"target": "es5",
5+
"experimentalDecorators": true,
6+
"emitDecoratorMetadata": true,
7+
"noEmitHelpers": true,
8+
"noEmitOnError": true,
9+
"skipLibCheck": true,
10+
"lib": [
11+
"es6",
12+
"dom",
13+
"es2015.iterable"
14+
],
15+
"baseUrl": ".",
16+
"paths": {
17+
"~/*": [
18+
"src/*"
19+
],
20+
"*": [
21+
"./node_modules/*"
22+
]
23+
}
24+
},
25+
"exclude": [
26+
"node_modules",
27+
"platforms"
28+
]
29+
}

Diff for: demo-ng/tsconfig.tns.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"extends": "./tsconfig",
3-
"compilerOptions": {
4-
"module": "es2015",
5-
"moduleResolution": "node"
6-
}
2+
"extends": "./tsconfig",
3+
"compilerOptions": {
4+
"module": "esNext",
5+
"moduleResolution": "node"
6+
}
77
}

Diff for: demo-ng/webpack.config.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ module.exports = env => {
3535

3636
const {
3737
// The 'appPath' and 'appResourcesPath' values are fetched from
38-
// the nsconfig.json configuration file
39-
// when bundling with `tns run android|ios --bundle`.
38+
// the nsconfig.json configuration file.
4039
appPath = "src",
4140
appResourcesPath = "App_Resources",
4241

@@ -197,7 +196,7 @@ module.exports = env => {
197196
module: {
198197
rules: [
199198
{
200-
test: nsWebpack.getEntryPathRegExp(appFullPath, entryPath),
199+
include: join(appFullPath, entryPath),
201200
use: [
202201
// Require all Android app components
203202
platform === "android" && {

Diff for: demo/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"ci.tslint": "npm i && tslint --config '../tslint.json' 'demoapp/**/*.ts' --exclude '**/node_modules/**' --exclude '**/typings/**'"
3232
},
3333
"dependencies": {
34-
"nativescript-app-sync": "file:../publish/package/nativescript-app-sync-1.0.6.tgz",
34+
"nativescript-app-sync": "file:../publish/package/nativescript-app-sync-1.0.7.tgz",
3535
"nativescript-theme-core": "~1.0.4",
3636
"nativescript-unit-test-runner": "0.7.0",
3737
"tns-core-modules": "~6.0.0"

Diff for: src/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-app-sync",
3-
"version": "1.0.6",
3+
"version": "1.0.7",
44
"description": "Use AppSync to hot deploy updates to your app.",
55
"main": "app-sync",
66
"typings": "index.d.ts",
@@ -68,7 +68,7 @@
6868
"homepage": "https://github.com/eddyverbruggen/nativescript-app-sync",
6969
"readmeFilename": "README.md",
7070
"dependencies": {
71-
"nativescript-app-sync-cli": "~1.0.1",
71+
"nativescript-app-sync-sdk": "~1.0.1",
7272
"nativescript-appversion": "~1.4.2",
7373
"nativescript-hook": "~0.2.5",
7474
"nativescript-zip": "git+https://github.com/EddyVerbruggen/nativescript-zip.git#330fa2d"

0 commit comments

Comments
 (0)