Merge pull request #2613 from Neamar/looper-handler

Stop using Handler() without the main looper

Author: marunjar

app/src/main/java/fr/neamar/kiss/DataHandler.java

@@ -13,6 +13,7 @@
 import android.os.Build;
 import android.os.Handler;
 import android.os.IBinder;
+import android.os.Looper;
 import android.os.UserManager;
 import android.text.TextUtils;
 import android.util.Pair;
@@ -234,7 +235,7 @@ public void onReceive(final Context context, Intent intent) {
                     boolean isPhoneLocked = myKM.inKeyguardRestrictedInputMode();
                     if (!isPhoneLocked) {
                         context.unregisterReceiver(this);
-                        final Handler handler = new Handler();
+                        final Handler handler = new Handler(Looper.getMainLooper());
                         // Even when all the stars are aligned,
                         // starting the service needs to be slightly delayed because the Intent is fired *before* the app is considered in the foreground.
                         // Each new release of Android manages to make the developer life harder.

app/src/main/java/fr/neamar/kiss/forwarder/Widgets.java

@@ -13,6 +13,7 @@
 import android.content.Intent;
 import android.os.Build;
 import android.os.Handler;
+import android.os.Looper;
 import android.os.UserHandle;
 import android.text.TextUtils;
 import android.view.ContextMenu;
@@ -437,7 +438,7 @@ private void requestBindWidget(@NonNull Intent data) {
         final ComponentName provider = data.getParcelableExtra(AppWidgetManager.EXTRA_APPWIDGET_PROVIDER);
         final UserHandle profile = data.getParcelableExtra(AppWidgetManager.EXTRA_APPWIDGET_PROVIDER_PROFILE);
 
-        new Handler().postDelayed(() -> {
+        new Handler(Looper.getMainLooper()).postDelayed(() -> {
             Log.d(TAG, "asking for permission");
 
             Intent intent = new Intent(AppWidgetManager.ACTION_APPWIDGET_BIND);

app/src/main/java/fr/neamar/kiss/result/Result.java

@@ -9,6 +9,7 @@
 import android.graphics.Typeface;
 import android.graphics.drawable.Drawable;
 import android.os.Handler;
+import android.os.Looper;
 import android.text.Spannable;
 import android.text.SpannableString;
 import android.text.style.ForegroundColorSpan;
@@ -395,7 +396,7 @@ protected final void recordLaunch(Context context, @Nullable QueryInterface quer
         // * to ensure the animation runs smoothly
         // * to avoid a flickering -- launchOccurred will refresh the list
         // Thus TOUCH_DELAY * 3
-        Handler handler = new Handler();
+        Handler handler = new Handler(Looper.getMainLooper());
         handler.postDelayed(() -> {
             if (queryInterface != null) {
                 queryInterface.launchOccurred();
@@ -596,7 +597,7 @@ protected void setTranscriptModeAlwaysScroll(RecordAdapter adapter) {
         // We'll need to reset the list view to its previous transcript mode,
         // but it has to happen *after* the keyboard is hidden, otherwise scroll will be reset
         // Let's wait for half a second, that's ugly but we don't have any other option :(
-        final Handler handler = new Handler();
+        final Handler handler = new Handler(Looper.getMainLooper());
         handler.postDelayed(() -> adapter.updateTranscriptMode(AbsListView.TRANSCRIPT_MODE_ALWAYS_SCROLL), 500);
     }