Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ravines #12

Open
b1zeyofficial opened this issue Feb 26, 2025 · 3 comments
Open

Add Ravines #12

b1zeyofficial opened this issue Feb 26, 2025 · 3 comments

Comments

@b1zeyofficial
Copy link

It would be nice if RavinesPopulator was added. Or a guide on how to build

Image

Image

@b1zeyofficial
Copy link
Author

b1zeyofficial commented Feb 26, 2025

There is also another problem, it is that the world generation goes to 0 but in Chunk.h the value is set to -64. This allows the player to place blocks below 0. What NG fork pmmp will not comply with

static const int Y_MIN = -64;

for (int_fast16_t y = 255; y >= 0; --y) {

Image

Image

@b1zeyofficial
Copy link
Author

@larryTheCoder

@b1zeyofficial
Copy link
Author

There is also another problem, it is that the world generation goes to 0 but in Chunk.h the value is set to -64. This allows the player to place blocks below 0. What NG fork pmmp will not comply with

ext-vanillagenerator/lib/chunk/Chunk.h

Line 12 in abd059f

static const int Y_MIN = -64;

ext-vanillagenerator/lib/generator/ground/GroundGenerator.cpp

Line 39 in abd059f

for (int_fast16_t y = 255; y >= 0; --y) {
Image

Image

most likely this is a problem with pmmp, since there the generator also generates coordinates up to 0 and chunks are also -64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant