Vectorized Multiply (on Avx512) (#45)

* avx512 multiply * Optimize * optimize * optimize * Optimize * Optimize * Simplify * Optimize * Optimize * optimize * Recoment and rename * Optimize * Optimize * Fix benchmarks * Temp refactor * Improved comments * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Otpimize * Refactor * Clean up comments * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Optimize * Revert "Optimize" This reverts commit f380ecf. * Optimize
NethermindEth · Feb 10, 2025 · 7d7b936 · 7d7b936
1 parent 992083e
commit 7d7b936
Show file tree

Hide file tree

Showing 3 changed files with 206 additions and 62 deletions.
diff --git a/src/Nethermind.Int256.Benchmark/Benchmarks.cs b/src/Nethermind.Int256.Benchmark/Benchmarks.cs
@@ -89,8 +89,8 @@ public class SignedIntTwoParamBenchmarkBase : SignedBenchmarkBase
         public (int, Int256) D;
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class AddUnsigned : UnsignedTwoParamBenchmarkBase
     {
@@ -108,8 +108,8 @@ public UInt256 Add_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class AddSigned : SignedTwoParamBenchmarkBase
     {
@@ -127,8 +127,8 @@ public Int256 Add_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class SubtractUnsigned : UnsignedTwoParamBenchmarkBase
     {
@@ -146,8 +146,8 @@ public UInt256 Subtract_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class SubtractSigned : SignedTwoParamBenchmarkBase
     {
@@ -165,8 +165,8 @@ public Int256 Subtract_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class AddModUnsinged : UnsignedThreeParamBenchmarkBase
     {
@@ -184,8 +184,8 @@ public UInt256 AddMod_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class AddModSinged : SignedThreeParamBenchmarkBase
     {
@@ -203,8 +203,8 @@ public Int256 AddMod_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class SubtractModUnsinged : UnsignedThreeParamBenchmarkBase
     {
@@ -222,8 +222,8 @@ public UInt256 SubtractMod_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class SubtractModSigned : SignedThreeParamBenchmarkBase
     {
@@ -241,8 +241,8 @@ public Int256 SubtractMod_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class MultiplyUnsigned : UnsignedTwoParamBenchmarkBase
     {
@@ -260,8 +260,8 @@ public UInt256 Multiply_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class MultiplySigned : SignedTwoParamBenchmarkBase
     {
@@ -279,8 +279,8 @@ public Int256 Multiply_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class MultiplyModUnsigned : UnsignedThreeParamBenchmarkBase
     {
@@ -298,8 +298,8 @@ public UInt256 MultiplyMod_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class MultiplyModSigned : SignedThreeParamBenchmarkBase
     {
@@ -317,8 +317,8 @@ public Int256 MultiplyMod_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class DivideUnsigned : UnsignedTwoParamBenchmarkBase
     {
@@ -336,8 +336,8 @@ public UInt256 Divide_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class DivideSigned : SignedTwoParamBenchmarkBase
     {
@@ -355,8 +355,8 @@ public Int256 Divide_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class ExpUnsigned : UnsignedIntTwoParamBenchmarkBase
     {
@@ -374,8 +374,8 @@ public UInt256 Exp_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class ExpSigned : SignedIntTwoParamBenchmarkBase
     {
@@ -393,8 +393,8 @@ public Int256 Exp_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class ExpModUnsigned : UnsignedThreeParamBenchmarkBase
     {
@@ -412,8 +412,8 @@ public UInt256 ExpMod_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class ExpModSigned : SignedBenchmarkBase
     {
@@ -440,8 +440,8 @@ public Int256 ExpMod_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class LeftShiftUnsigned : UnsignedIntTwoParamBenchmarkBase
     {
@@ -459,8 +459,8 @@ public UInt256 LeftShift_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class LeftShiftSigned : SignedIntTwoParamBenchmarkBase
     {
@@ -478,8 +478,8 @@ public Int256 LeftShift_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class RightShiftUnsigned : UnsignedIntTwoParamBenchmarkBase
     {
@@ -497,8 +497,8 @@ public UInt256 RightShift_UInt256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class RightShiftSigned : SignedIntTwoParamBenchmarkBase
     {
@@ -516,8 +516,8 @@ public Int256 RightShift_Int256()
         }
     }
 
-    [SimpleJob(RuntimeMoniker.Net70, baseline: true)]
-    [NoIntrinsicsJob(RuntimeMoniker.Net70)]
+    [SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+    [NoIntrinsicsJob(RuntimeMoniker.Net90)]
     [MemoryDiagnoser]
     public class IsZeroOne
     {

diff --git a/src/Nethermind.Int256.Benchmark/NoIntrinsicsJobAttribute.cs b/src/Nethermind.Int256.Benchmark/NoIntrinsicsJobAttribute.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
@@ -116,6 +116,8 @@ internal static Runtime GetRuntime(this RuntimeMoniker runtimeMoniker)
                     return CoreRuntime.Core70;
                 case RuntimeMoniker.Net80:
                     return CoreRuntime.Core80;
+                case RuntimeMoniker.Net90:
+                    return CoreRuntime.Core90;
                 case RuntimeMoniker.Mono:
                     return MonoRuntime.Default;
                 case RuntimeMoniker.NativeAot60: