Merge pull request #141 from plural/illustrator-num-printings

Illustrator num printings

Author: plural

app/resources/api/v3/public/illustrator_resource.rb

@@ -4,7 +4,7 @@ module Public
       class Api::V3::Public::IllustratorResource < JSONAPI::Resource
         immutable
 
-        attributes :name, :updated_at
+        attributes :name, :num_printings, :updated_at
         key_type :string
 
         paginator :none

db/migrate/20221125223355_add_num_printings_to_illustrators.rb

@@ -0,0 +1,5 @@
+class AddNumPrintingsToIllustrators < ActiveRecord::Migration[7.0]
+  def change
+    add_column :illustrators, :num_printings, :integer
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2022_11_25_065640) do
+ActiveRecord::Schema[7.0].define(version: 2022_11_25_223355) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -148,6 +148,7 @@
     t.string "name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.integer "num_printings"
   end
 
   create_table "illustrators_printings", id: false, force: :cascade do |t|

doc/api/illustrators/all_illustrators.json

@@ -25,7 +25,7 @@
       "request_content_type": "application/json",
       "response_status": 200,
       "response_status_text": "OK",
-      "response_body": "{\n  \"data\": [\n    {\n      \"id\": \"ann_illustrator\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator\"\n      },\n      \"attributes\": {\n        \"name\": \"Ann Illustrator\",\n        \"updated_at\": \"2022-11-25T07:06:27.064Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/printings\"\n          }\n        }\n      }\n    },\n    {\n      \"id\": \"good_drawers\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers\"\n      },\n      \"attributes\": {\n        \"name\": \"Good Drawers\",\n        \"updated_at\": \"2022-11-25T07:06:27.064Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers/printings\"\n          }\n        }\n      }\n    },\n    {\n      \"id\": \"tom_of_netrunner\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner\"\n      },\n      \"attributes\": {\n        \"name\": \"Tom of Netrunner\",\n        \"updated_at\": \"2022-11-25T07:06:27.064Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings\"\n          }\n        }\n      }\n    }\n  ]\n}",
+      "response_body": "{\n  \"data\": [\n    {\n      \"id\": \"ann_illustrator\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator\"\n      },\n      \"attributes\": {\n        \"name\": \"Ann Illustrator\",\n        \"num_printings\": 1,\n        \"updated_at\": \"2022-11-25T22:52:21.616Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/printings\"\n          }\n        }\n      }\n    },\n    {\n      \"id\": \"good_drawers\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers\"\n      },\n      \"attributes\": {\n        \"name\": \"Good Drawers\",\n        \"num_printings\": 1,\n        \"updated_at\": \"2022-11-25T22:52:21.616Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/good_drawers/printings\"\n          }\n        }\n      }\n    },\n    {\n      \"id\": \"tom_of_netrunner\",\n      \"type\": \"illustrators\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner\"\n      },\n      \"attributes\": {\n        \"name\": \"Tom of Netrunner\",\n        \"num_printings\": 1,\n        \"updated_at\": \"2022-11-25T22:52:21.616Z\"\n      },\n      \"relationships\": {\n        \"printings\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/relationships/printings\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings\"\n          }\n        }\n      }\n    }\n  ]\n}",
       "response_headers": {
         "Content-Type": "application/vnd.api+json"
       },

doc/api/illustrators/get_a_single_illustrator.json

@@ -30,7 +30,7 @@
       "request_content_type": "application/json",
       "response_status": 200,
       "response_status_text": "OK",
-      "response_body": "{\n  \"data\": {\n    \"id\": \"ann_illustrator\",\n    \"type\": \"illustrators\",\n    \"links\": {\n      \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator\"\n    },\n    \"attributes\": {\n      \"name\": \"Ann Illustrator\",\n      \"updated_at\": \"2022-11-25T07:06:27.064Z\"\n    },\n    \"relationships\": {\n      \"printings\": {\n        \"links\": {\n          \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/relationships/printings\",\n          \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/printings\"\n        }\n      }\n    }\n  }\n}",
+      "response_body": "{\n  \"data\": {\n    \"id\": \"ann_illustrator\",\n    \"type\": \"illustrators\",\n    \"links\": {\n      \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator\"\n    },\n    \"attributes\": {\n      \"name\": \"Ann Illustrator\",\n      \"num_printings\": 1,\n      \"updated_at\": \"2022-11-25T22:52:21.616Z\"\n    },\n    \"relationships\": {\n      \"printings\": {\n        \"links\": {\n          \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/relationships/printings\",\n          \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/ann_illustrator/printings\"\n        }\n      }\n    }\n  }\n}",
       "response_headers": {
         "Content-Type": "application/vnd.api+json"
       },

doc/api/illustrators/relationship_-_get_printings_for_an_illustrator.json

@@ -30,7 +30,7 @@
       "request_content_type": "application/json",
       "response_status": 200,
       "response_status_text": "OK",
-      "response_body": "{\n  \"data\": [\n    {\n      \"id\": \"01056\",\n      \"type\": \"printings\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056\"\n      },\n      \"attributes\": {\n        \"card_id\": \"adonis_campaign\",\n        \"card_cycle_id\": \"core\",\n        \"card_cycle_name\": \"Core Set\",\n        \"card_set_id\": \"core\",\n        \"card_set_name\": \"Core\",\n        \"printed_text\": \"Gain Money at the start of your turn\",\n        \"stripped_printed_text\": \"Gain Money at the start of your turn\",\n        \"printed_is_unique\": false,\n        \"flavor\": \"Beefy Boi\",\n        \"display_illustrators\": \"Tom of Netrunner\",\n        \"illustrator_ids\": [\n          \"tom_of_netrunner\"\n        ],\n        \"illustrator_names\": [\n          \"Tom of Netrunner\"\n        ],\n        \"position\": 56,\n        \"quantity\": 3,\n        \"date_release\": \"2012-09-06\",\n        \"updated_at\": \"2022-11-25T07:06:27.065Z\",\n        \"advancement_requirement\": null,\n        \"agenda_points\": null,\n        \"base_link\": null,\n        \"card_type_id\": \"asset\",\n        \"cost\": null,\n        \"deck_limit\": null,\n        \"display_subtypes\": null,\n        \"card_subtype_ids\": [\n          \"advertisement\"\n        ],\n        \"card_subtype_names\": [\n          \"Advertisement\"\n        ],\n        \"faction_id\": \"haas_bioroid\",\n        \"influence_cost\": null,\n        \"influence_limit\": null,\n        \"is_unique\": null,\n        \"memory_cost\": null,\n        \"minimum_deck_size\": null,\n        \"side_id\": \"corp\",\n        \"strength\": null,\n        \"stripped_text\": null,\n        \"stripped_title\": \"Adonis Campaign\",\n        \"text\": null,\n        \"title\": \"Adonis Campaign\",\n        \"trash_cost\": null,\n        \"printing_ids\": [\n          \"01056\"\n        ],\n        \"num_printings\": 1,\n        \"restriction_ids\": [\n\n        ],\n        \"in_restriction\": false,\n        \"format_ids\": [\n\n        ],\n        \"card_pool_ids\": [\n\n        ],\n        \"snapshot_ids\": [\n\n        ],\n        \"attribution\": null,\n        \"card_abilities\": {\n          \"additional_cost\": false,\n          \"advanceable\": false,\n          \"gains_subroutines\": false,\n          \"interrupt\": false,\n          \"link_provided\": null,\n          \"mu_provided\": null,\n          \"num_printed_subroutines\": null,\n          \"on_encounter_effect\": false,\n          \"performs_trace\": false,\n          \"recurring_credits_provided\": null,\n          \"rez_effect\": false,\n          \"trash_ability\": false\n        },\n        \"images\": {\n          \"nrdb_classic\": {\n            \"tiny\": \"https://static.nrdbassets.com/v1/tiny/01056.jpg\",\n            \"small\": \"https://static.nrdbassets.com/v1/small/01056.jpg\",\n            \"medium\": \"https://static.nrdbassets.com/v1/medium/01056.jpg\",\n            \"large\": \"https://static.nrdbassets.com/v1/large/01056.jpg\"\n          }\n        },\n        \"latest_printing_id\": \"01056\",\n        \"restrictions\": {\n          \"banned\": [\n\n          ],\n          \"global_penalty\": [\n\n          ],\n          \"points\": {\n          },\n          \"restricted\": [\n\n          ],\n          \"universal_faction_cost\": {\n          }\n        }\n      },\n      \"relationships\": {\n        \"card\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card\"\n          }\n        },\n        \"card_cycle\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card_cycle\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card_cycle\"\n          }\n        },\n        \"card_set\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card_set\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card_set\"\n          }\n        },\n        \"faction\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/faction\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/faction\"\n          }\n        },\n        \"illustrators\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/illustrators\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/illustrators\"\n          }\n        },\n        \"side\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/side\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/side\"\n          }\n        }\n      }\n    }\n  ],\n  \"links\": {\n    \"first\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings?page%5Blimit%5D=100&page%5Boffset%5D=0\",\n    \"last\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings?page%5Blimit%5D=100&page%5Boffset%5D=0\"\n  }\n}",
+      "response_body": "{\n  \"data\": [\n    {\n      \"id\": \"01056\",\n      \"type\": \"printings\",\n      \"links\": {\n        \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056\"\n      },\n      \"attributes\": {\n        \"card_id\": \"adonis_campaign\",\n        \"card_cycle_id\": \"core\",\n        \"card_cycle_name\": \"Core Set\",\n        \"card_set_id\": \"core\",\n        \"card_set_name\": \"Core\",\n        \"printed_text\": \"Gain Money at the start of your turn\",\n        \"stripped_printed_text\": \"Gain Money at the start of your turn\",\n        \"printed_is_unique\": false,\n        \"flavor\": \"Beefy Boi\",\n        \"display_illustrators\": \"Tom of Netrunner\",\n        \"illustrator_ids\": [\n          \"tom_of_netrunner\"\n        ],\n        \"illustrator_names\": [\n          \"Tom of Netrunner\"\n        ],\n        \"position\": 56,\n        \"quantity\": 3,\n        \"date_release\": \"2012-09-06\",\n        \"updated_at\": \"2022-11-25T22:52:21.617Z\",\n        \"advancement_requirement\": null,\n        \"agenda_points\": null,\n        \"base_link\": null,\n        \"card_type_id\": \"asset\",\n        \"cost\": null,\n        \"deck_limit\": null,\n        \"display_subtypes\": null,\n        \"card_subtype_ids\": [\n          \"advertisement\"\n        ],\n        \"card_subtype_names\": [\n          \"Advertisement\"\n        ],\n        \"faction_id\": \"haas_bioroid\",\n        \"influence_cost\": null,\n        \"influence_limit\": null,\n        \"is_unique\": null,\n        \"memory_cost\": null,\n        \"minimum_deck_size\": null,\n        \"side_id\": \"corp\",\n        \"strength\": null,\n        \"stripped_text\": null,\n        \"stripped_title\": \"Adonis Campaign\",\n        \"text\": null,\n        \"title\": \"Adonis Campaign\",\n        \"trash_cost\": null,\n        \"printing_ids\": [\n          \"01056\"\n        ],\n        \"num_printings\": 1,\n        \"restriction_ids\": [\n\n        ],\n        \"in_restriction\": false,\n        \"format_ids\": [\n\n        ],\n        \"card_pool_ids\": [\n\n        ],\n        \"snapshot_ids\": [\n\n        ],\n        \"attribution\": null,\n        \"card_abilities\": {\n          \"additional_cost\": false,\n          \"advanceable\": false,\n          \"gains_subroutines\": false,\n          \"interrupt\": false,\n          \"link_provided\": null,\n          \"mu_provided\": null,\n          \"num_printed_subroutines\": null,\n          \"on_encounter_effect\": false,\n          \"performs_trace\": false,\n          \"recurring_credits_provided\": null,\n          \"rez_effect\": false,\n          \"trash_ability\": false\n        },\n        \"images\": {\n          \"nrdb_classic\": {\n            \"tiny\": \"https://static.nrdbassets.com/v1/tiny/01056.jpg\",\n            \"small\": \"https://static.nrdbassets.com/v1/small/01056.jpg\",\n            \"medium\": \"https://static.nrdbassets.com/v1/medium/01056.jpg\",\n            \"large\": \"https://static.nrdbassets.com/v1/large/01056.jpg\"\n          }\n        },\n        \"latest_printing_id\": \"01056\",\n        \"restrictions\": {\n          \"banned\": [\n\n          ],\n          \"global_penalty\": [\n\n          ],\n          \"points\": {\n          },\n          \"restricted\": [\n\n          ],\n          \"universal_faction_cost\": {\n          }\n        }\n      },\n      \"relationships\": {\n        \"card\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card\"\n          }\n        },\n        \"card_cycle\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card_cycle\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card_cycle\"\n          }\n        },\n        \"card_set\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/card_set\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/card_set\"\n          }\n        },\n        \"faction\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/faction\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/faction\"\n          }\n        },\n        \"illustrators\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/illustrators\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/illustrators\"\n          }\n        },\n        \"side\": {\n          \"links\": {\n            \"self\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/relationships/side\",\n            \"related\": \"http://api-preview.netrunnerdb.com/api/v3/public/printings/01056/side\"\n          }\n        }\n      }\n    }\n  ],\n  \"links\": {\n    \"first\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings?page%5Blimit%5D=100&page%5Boffset%5D=0\",\n    \"last\": \"http://api-preview.netrunnerdb.com/api/v3/public/illustrators/tom_of_netrunner/printings?page%5Blimit%5D=100&page%5Boffset%5D=0\"\n  }\n}",
       "response_headers": {
         "Content-Type": "application/vnd.api+json"
       },

lib/tasks/cards.rake

@@ -339,6 +339,7 @@ namespace :cards do
 
       illustrators = Set[]
       illustrators_to_printings = []
+      illustrator_num_printings = {}
       num_its = 0
       printings = Printing.all
       printings.each { |printing|
@@ -350,6 +351,10 @@ namespace :cards do
               "illustrator_id": text_to_id(i),
               "printing_id": printing.id
             }
+            if !illustrator_num_printings.key?(i)
+              illustrator_num_printings[i] = 0
+            end
+            illustrator_num_printings[i] += 1
           }
         end
       }
@@ -358,7 +363,8 @@ namespace :cards do
       illustrators.each { |i|
         ill << {
           "id": text_to_id(i),
-          "name": i
+          "name": i,
+          "num_printings": illustrator_num_printings[i]
         }
       }
 

test/fixtures/illustrators.yml

@@ -1,11 +1,14 @@
 good_drawers:
   id: good_drawers
   name: "Good Drawers"
+  num_printings: 1
 
 ann_illustrator:
   id: ann_illustrator
   name: "Ann Illustrator"
+  num_printings: 1
 
 tom_of_netrunner:
   id: tom_of_netrunner
-  name: "Tom of Netrunner"
+  name: "Tom of Netrunner"
+  num_printings: 1