Add tests for global penalty and universal influence.

Author: plural

lib/deck_validator.rb

@@ -156,8 +156,8 @@ def is_valid?
               if global_penalty > 0 and !@identity.influence_limit.nil?
                 influence_limit = [(@identity.influence_limit - global_penalty), 1].max
                 if @basic_influence_spent > influence_limit
-                  v.add_error('Influence limit for %s is %d after Global Penalty applied from restriction `%s`, but deck has spent %d influence from %s.' % [@identity.title, influence_limit, v.restriction_id, @basic_influence_spent, cards_with_global_penalty.join(', ')])
-                @validation_errors = true
+                  v.add_error('Influence limit for %s is %d after Global Penalty applied from restriction `%s`, but deck has spent %d influence from %s.' % [@identity.title, influence_limit, v.restriction_id, global_penalty, cards_with_global_penalty.join(', ')])
+                  @validation_errors = true
                 end
               end
             end

test/fixtures/card_pools_cards.yml

@@ -38,6 +38,62 @@ standard_02_trieste_model_bioroids:
   card_id: trieste_model_bioroids
   card_pool_id: standard_02
 
+#standard_02_ikawah_project:
+#  card_id: ikawah_project
+#  card_pool_id: standard_02
+#
+#standard_02_project_vitruvius:
+#   card_id: project_vitruvius
+#   card_pool_id: standard_02
+
+# standard_02_regolith_mining_license:
+#   card_id: regolith_mining_license
+#   card_pool_id: standard_02
+
+# standard_02_spin_doctor:
+#   card_id: spin_doctor
+#   card_pool_id: standard_02
+
+# standard_02_biotic_labor:
+#   card_id: biotic_labor
+#   card_pool_id: standard_02
+
+standard_02_punitive_counterstrike:
+  card_id: punitive_counterstrike
+  card_pool_id: standard_02
+
+# standard_02_eli_1_0:
+#   card_id: eli_1_0
+#   card_pool_id: standard_02
+
+# standard_02_hagen:
+#   card_id: hagen
+#   card_pool_id: standard_02
+
+# standard_02_hakarl_1_0:
+#   card_id: hakarl_1_0
+#   card_pool_id: standard_02
+
+# standard_02_enigma:
+#   card_id: enigma
+#   card_pool_id: standard_02
+
+# standard_02_tollbooth:
+#   card_id: tollbooth
+#   card_pool_id: standard_02
+
+# standard_02_ansel_1_0:
+#   card_id: ansel_1_0
+#   card_pool_id: standard_02
+
+# standard_02_rototurret:
+#   card_id: rototurret
+#   card_pool_id: standard_02
+
+standard_02_tyr:
+  card_id: tyr
+  card_pool_id: standard_02
+
 startup_01_prisec:
   card_id: prisec
   card_pool_id: startup_01

test/fixtures/restrictions.yml

@@ -22,3 +22,18 @@ standard_restricted:
   created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
   updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
 
+standard_global_penalty:
+  id: standard_global_penalty
+  name: "Standard Global Penalty"
+  format_id: "standard"
+  date_start: 2023-08-26
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+
+standard_universal_faction_cost:
+  id: standard_universal_faction_cost
+  name: "Standard Universal Faction Cost"
+  format_id: "standard"
+  date_start: 2023-08-26
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>

test/fixtures/restrictions_cards_global_penalty.yml

@@ -0,0 +1,5 @@
+tyr_global_penalty:
+  restriction_id: standard_global_penalty
+  card_id: tyr
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>

test/fixtures/restrictions_cards_universal_faction_cost.yml

@@ -0,0 +1,6 @@
+punitive_counterstrike_points:
+  restriction_id: standard_universal_faction_cost
+  card_id: punitive_counterstrike
+  value: 3
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>

test/fixtures/snapshots.yml

@@ -22,11 +22,31 @@ standard_03:
   format_id: standard
   card_pool_id: standard_02
   date_start: 2022-09-06
-  active: true
+  active: false
   restriction_id: standard_restricted
   created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
   updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
 
+standard_04:
+  id: standard_04
+  format_id: standard
+  card_pool_id: standard_02
+  date_start: 2022-09-06
+  active: false
+  restriction_id: standard_global_penalty
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+
+standard_05:
+  id: standard_05
+  format_id: standard
+  card_pool_id: standard_02
+  date_start: 2022-09-06
+  active: false
+  restriction_id: standard_universal_faction_cost
+  created_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+  updated_at: <%= Time.utc(2022, 12, 8, 12, 0).to_fs(:db) %>
+
 startup_01:
   id: startup_01
   format_id: startup

test/unit/deck_validator_test.rb

@@ -698,12 +698,10 @@ def test_cards_not_in_specified_card_pool
       'hakarl_1_0',
       'ikawah_project',
       'project_vitruvius',
-      'punitive_counterstrike',
       'regolith_mining_license',
       'rototurret',
       'spin_doctor',
       'tollbooth',
-      'tyr'
     ].each do |c|
       assert_includes v.validations[0].errors, "Card `%s` is not present in Card Pool `standard_02`." % c
     end
@@ -735,6 +733,32 @@ def test_too_many_restricted_cards
     assert_includes v.validations[0].errors, 'Deck has too many cards marked restricted in restriction `standard_restricted`: send_a_message, trieste_model_bioroids.'
   end
 
+  def test_global_penalty_reduces_influence
+    deck = @good_asa_group.deep_dup
+    deck['validations'][0]['restriction_id'] = 'standard_global_penalty'
+    deck['validations'][0].delete('format_id')
+    deck['validations'][0].delete('card_pool_id')
+    deck['validations'][0].delete('snapshot_id')
+
+    v = DeckValidator.new(deck)
+    assert !v.is_valid?
+    assert_equal v.validations.size, deck['validations'].size
+    assert_includes v.validations[0].errors, 'Influence limit for Asa Group: Security Through Vigilance is 13 after Global Penalty applied from restriction `standard_global_penalty`, but deck has spent 2 influence from tyr (2).'
+  end
+
+  def test_universal_influence
+    deck = @good_asa_group.deep_dup
+    deck['validations'][0]['restriction_id'] = 'standard_universal_faction_cost'
+    deck['validations'][0].delete('format_id')
+    deck['validations'][0].delete('card_pool_id')
+    deck['validations'][0].delete('snapshot_id')
+
+    v = DeckValidator.new(deck)
+    assert !v.is_valid?
+    assert_equal v.validations.size, deck['validations'].size
+    assert_includes v.validations[0].errors, 'Influence limit for Asa Group: Security Through Vigilance is 15, but after Universal Influence applied from restriction `standard_universal_faction_cost`, deck has spent 24 influence from punitive_counterstrike (9).'
+  end
+
   def test_over_eternal_points_limit
     deck = @good_asa_group.deep_dup
     deck['validations'][0]['snapshot_id'] = 'eternal_01'