Cleanup

Author: migueldlr

app/resources/card_resource.rb

@@ -166,15 +166,15 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
   def images(id, face_index = nil)
     url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
     face_suffix = "-#{face_index}" unless face_index.nil?
-    has_narrative_image = :narrative_text.presence && !face_index.nil?
+    has_narrative_image = :narrative_text.presence && face_index.nil?
     image_sizes = {
       'tiny' => "#{url_prefix}/tiny/#{id}#{face_suffix}.jpg",
       'small' => "#{url_prefix}/small/#{id}#{face_suffix}.jpg",
       'medium' => "#{url_prefix}/medium/#{id}#{face_suffix}.jpg",
       'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg"
     }
 
-    image_sizes.merge!('narrative' => "#{url_prefix}/large/#{id}#{face_suffix}-narrative.jpg") if has_narrative_image
+    image_sizes['narrative'] = "#{url_prefix}/large/#{id}#{face_suffix}-narrative.jpg" if has_narrative_image
 
     {
       'nrdb_classic' => image_sizes

app/resources/printing_resource.rb

@@ -182,15 +182,15 @@ class PrintingResource < ApplicationResource # rubocop:disable Metrics/ClassLeng
   def images(id, face_index = nil)
     url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
     face_suffix = "-#{face_index}" unless face_index.nil?
-    has_narrative_image = :narrative_text.presence && !face_index.nil?
+    has_narrative_image = :narrative_text.presence && face_index.nil?
     image_sizes = {
       'tiny' => "#{url_prefix}/tiny/#{id}#{face_suffix}.jpg",
       'small' => "#{url_prefix}/small/#{id}#{face_suffix}.jpg",
       'medium' => "#{url_prefix}/medium/#{id}#{face_suffix}.jpg",
       'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg"
     }
 
-    image_sizes.merge!('narrative' => "#{url_prefix}/large/#{id}#{face_suffix}-narrative.jpg") if has_narrative_image
+    image_sizes['narrative'] = "#{url_prefix}/large/#{id}#{face_suffix}-narrative.jpg" if has_narrative_image
 
     {
       'nrdb_classic' => image_sizes