Flattened global penalty field to array instead of a mapping with one key

Author: distributive

app/resources/api/v3/public/restriction_resource.rb

@@ -17,7 +17,7 @@ def verdicts
           { 'banned': @model.banned_cards.pluck(:card_id),
             'restricted': @model.restricted_cards.pluck(:card_id),
             'universal_faction_cost': Hash[@model.universal_faction_cost_cards.pluck(:value, :card_id).group_by(&:first).map{ |k,a| [k,a.map(&:last)] }],
-            'global_penalty': Hash[@model.global_penalty_cards.pluck(:value, :card_id).group_by(&:first).map{ |k,a| [k,a.map(&:last)] }],
+            'global_penalty': @model.global_penalty_cards.pluck(:card_id),
             'points': Hash[@model.points_cards.pluck(:value, :card_id).group_by(&:first).map{ |k,a| [k,a.map(&:last)] }]
           }
         end

db/migrate/20220925113944_update_unified_restrictions_to_version_4.rb

@@ -0,0 +1,5 @@
+class UpdateUnifiedRestrictionsToVersion4 < ActiveRecord::Migration[7.0]
+  def change
+    update_view :unified_restrictions, materialized: true, version: 4, revert_to_version: 3
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2022_09_23_032558) do
+ActiveRecord::Schema[7.0].define(version: 2022_09_25_113944) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -195,7 +195,6 @@
   create_table "restrictions_cards_global_penalty", id: false, force: :cascade do |t|
     t.text "restriction_id", null: false
     t.text "card_id", null: false
-    t.integer "value", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
@@ -301,7 +300,6 @@
               ELSE false
           END AS is_restricted,
       COALESCE(restrictions_cards_points.value, 0) AS eternal_points,
-      COALESCE(restrictions_cards_global_penalty.value, 0) AS global_penalty,
       COALESCE(restrictions_cards_universal_faction_cost.value, 0) AS universal_faction_cost
      FROM ((((((cards_cross_restrictions_and_snapshots
        JOIN card_pools_cards ON (((card_pools_cards.card_pool_id = cards_cross_restrictions_and_snapshots.card_pool_id) AND (card_pools_cards.card_id = (cards_cross_restrictions_and_snapshots.card_id)::text))))

db/views/unified_restrictions_v04.sql

@@ -0,0 +1,48 @@
+WITH cards_cross_restrictions_and_snapshots AS (
+    SELECT
+        cards.id as card_id,
+        restrictions.id as restriction_id,
+        snapshots.id as snapshot_id,
+        snapshots.format_id as format_id,
+        snapshots.card_pool_id as card_pool_id,
+        snapshots.date_start as snapshot_date_start
+    FROM
+        cards, restrictions JOIN snapshots ON restrictions.id = snapshots.restriction_id
+)
+SELECT
+    cards_cross_restrictions_and_snapshots.format_id,
+    cards_cross_restrictions_and_snapshots.card_pool_id,
+    cards_cross_restrictions_and_snapshots.snapshot_id,
+    cards_cross_restrictions_and_snapshots.snapshot_date_start,
+    cards_cross_restrictions_and_snapshots.restriction_id,
+    cards_cross_restrictions_and_snapshots.card_id,
+    restrictions_cards_banned.restriction_id IS NOT NULL
+        OR restrictions_cards_restricted.restriction_id IS NOT NULL
+        OR restrictions_cards_points.restriction_id IS NOT NULL
+        OR restrictions_cards_global_penalty.restriction_id IS NOT NULL
+        OR restrictions_cards_universal_faction_cost.restriction_id IS NOT NULL
+        as in_restriction,
+    CASE WHEN restrictions_cards_banned.restriction_id IS NOT NULL THEN true ELSE false END AS is_banned,
+    CASE WHEN restrictions_cards_restricted.restriction_id IS NOT NULL THEN true ELSE false END AS is_restricted,
+    COALESCE(restrictions_cards_points.value, 0) AS eternal_points,
+    COALESCE(restrictions_cards_universal_faction_cost.value, 0) AS universal_faction_cost
+FROM
+    cards_cross_restrictions_and_snapshots
+    JOIN card_pools_cards ON card_pools_cards.card_pool_id = cards_cross_restrictions_and_snapshots.card_pool_id
+        AND card_pools_cards.card_id = cards_cross_restrictions_and_snapshots.card_id
+    LEFT OUTER JOIN restrictions_cards_banned ON
+        restrictions_cards_banned.restriction_id = cards_cross_restrictions_and_snapshots.restriction_id
+        AND restrictions_cards_banned.card_id = cards_cross_restrictions_and_snapshots.card_id
+    LEFT OUTER JOIN restrictions_cards_points ON
+        restrictions_cards_points.restriction_id = cards_cross_restrictions_and_snapshots.restriction_id
+        AND restrictions_cards_points.card_id = cards_cross_restrictions_and_snapshots.card_id
+    LEFT OUTER JOIN restrictions_cards_global_penalty ON
+        restrictions_cards_global_penalty.restriction_id = cards_cross_restrictions_and_snapshots.restriction_id
+        AND restrictions_cards_global_penalty.card_id = cards_cross_restrictions_and_snapshots.card_id
+    LEFT OUTER JOIN restrictions_cards_restricted ON
+        restrictions_cards_restricted.restriction_id = cards_cross_restrictions_and_snapshots.restriction_id
+        AND restrictions_cards_restricted.card_id = cards_cross_restrictions_and_snapshots.card_id
+    LEFT OUTER JOIN restrictions_cards_universal_faction_cost ON
+        restrictions_cards_universal_faction_cost.restriction_id = cards_cross_restrictions_and_snapshots.restriction_id
+        AND restrictions_cards_universal_faction_cost.card_id = cards_cross_restrictions_and_snapshots.card_id
+;

lib/tasks/cards.rake

@@ -578,8 +578,7 @@ namespace :cards do
           cards.each do |card|
             global_penalty << RestrictionCardGlobalPenalty.new(
               restriction_id: r['id'],
-              card_id: card,
-              value: cost
+              card_id: card
             )
           end
         end