Search only constructs a db query for alias names if it knows there is one

Author: distributive

src/AppBundle/Controller/SearchController.php

@@ -434,8 +434,7 @@ public function displayAction(
                 $conditions = $capsConditions;
             }
             // If there are still no results, try again but with aliases
-            else {
-                $cardsData->unaliasCardNames($conditions);
+            else if ($cardsData->unaliasCardNames($conditions)) {
                 $rows = $cardsData->get_search_rows($conditions, $sort, $locale);
             }
         }

src/AppBundle/Service/CardsData.php

@@ -971,12 +971,14 @@ public function unaliasCardNames(array &$conditions)
 
         // Check the conditions are non-empty
         if (!$title)
-            return;
+            return false;
 
         // If they are the substring of an alias for a card, replace the conditions with that card's name
         if ($match = current(preg_grep("/^$title/", array_keys($this->cardAliases)))) {
             $conditions = [["_", ":", $this->cardAliases[$match]]];
+            return true;
         }
+        return false;
     }
 
     public function buildQueryFromConditions(array $conditions)