Merge pull request #1663 from zm711/clean-up-import

Cleanup import to use `importlib.util.find_spec`

Author: apdavison

neo/io/__init__.py

@@ -280,24 +280,17 @@
 
 import pathlib
 from collections import Counter
+import importlib.util
 
-# try to import the neuroshare library.
+# check if neuroshare library exists
 # if it is present, use the neuroshareapiio to load neuroshare files
 # if it is not present, use the neurosharectypesio to load files
-try:
-    import neuroshare as ns
-except ModuleNotFoundError as err:
-    from neo.io.neurosharectypesio import NeurosharectypesIO as NeuroshareIO
-
-    # print("\n neuroshare library not found, loading data with ctypes" )
-    # print("\n to use the API be sure to install the library found at:")
-    # print("\n www.http://pythonhosted.org/neuroshare/")
 
-else:
+neuroshare_spec = importlib.util.find_spec("neuroshare")
+if neuroshare_spec is not None:
     from neo.io.neuroshareapiio import NeuroshareapiIO as NeuroshareIO
-
-    # print("neuroshare library successfully imported")
-    # print("\n loading with API...")
+else:
+    from neo.io.neurosharectypesio import NeurosharectypesIO as NeuroshareIO
 
 from neo.io.alphaomegaio import AlphaOmegaIO
 from neo.io.asciiimageio import AsciiImageIO

neo/io/baseio.py

@@ -13,11 +13,7 @@
 
 from __future__ import annotations
 from pathlib import Path
-
-try:
-    from collections.abc import Sequence
-except ImportError:
-    from collections import Sequence
+from collections.abc import Sequence
 import logging
 
 from neo import logging_handler

neo/io/nixio.py

@@ -27,6 +27,8 @@
 from uuid import uuid4
 import warnings
 from packaging.version import Version
+import importlib.util
+import importlib.metadata
 
 import quantities as pq
 import numpy as np
@@ -122,17 +124,15 @@ def dt_from_nix(nixdt, annotype):
 
 
 def check_nix_version():
-    try:
-        import nixio
-    except ImportError:
-        raise Exception(
+    nixio_spec = importlib.util.find_spec("nixio")
+    if nixio_spec is None:
+        raise ImportError(
             "Failed to import NIX. "
             "The NixIO requires the Python package for NIX "
             "(nixio on PyPi). Try `pip install nixio`."
         )
 
-    # nixio version numbers have a 'v' prefix which breaks the comparison
-    nixverstr = nixio.__version__.lstrip("v")
+    nixverstr = importlib.metadata.version("nixio")
     try:
         nixver = Version(nixverstr)
     except ValueError:

neo/io/stimfitio.py

@@ -26,6 +26,8 @@
 08 Feb 2014, C. Schmidt-Hieber, University College London
 """
 
+import importlib.util
+
 import numpy as np
 import quantities as pq
 
@@ -92,7 +94,9 @@ def __init__(self, filename=None):
         """
         # We need this module, so try importing now so that it fails on
         # instantiation rather than read_block
-        import stfio  # noqa
+        stfio_spec = importlib.util.find_spec("stfio")
+        if stfio_spec is None:
+            raise ImportError("stfio must be installed to use StimfitIO")
 
         BaseIO.__init__(self)