Skip to content

Commit 4ef2801

Browse files
Merge pull request #1314 from apdavison/no-segments-in-group
do not allow Groups to contain Segments
2 parents 275e70b + 6524d19 commit 4ef2801

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

neo/core/group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class Group(Container):
5151
'AnalogSignal', 'IrregularlySampledSignal', 'SpikeTrain',
5252
'Event', 'Epoch', 'ChannelView', 'ImageSequence'
5353
)
54-
_container_child_objects = ('Segment', 'Group')
54+
_container_child_objects = ('Group',)
5555
_parent_objects = ('Block',)
5656

5757
def __init__(self, objects=None, name=None, description=None, file_origin=None,

neo/test/coretest/test_group.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def setUp(self):
4141
self.test_segment.spiketrains.extend(self.test_spiketrains)
4242

4343
def test_create_group(self):
44-
objects = [self.test_view, self.test_signal, self.test_segment]
44+
objects = [self.test_view, self.test_signal]
4545
objects.extend(self.test_spiketrains)
4646
group = Group(objects)
4747

@@ -50,21 +50,19 @@ def test_create_group(self):
5050
assert group.spiketrains[1] is self.test_spiketrains[1]
5151
assert group.channelviews[0] is self.test_view
5252
assert len(group.irregularlysampledsignals) == 0
53-
assert group.segments[0].analogsignals[0] is self.test_signal
5453

5554
def test_create_empty_group(self):
5655
group = Group()
5756

5857
def test_children(self):
5958
group = Group(self.test_spiketrains + [self.test_view]
60-
+ [self.test_signal] + [self.test_segment])
59+
+ [self.test_signal])
6160

6261
# note: ordering is by class name for data children (AnalogSignal, SpikeTrain),
6362
# then container children (Segment)
6463
assert group.children == (self.test_signal,
6564
*self.test_spiketrains,
66-
self.test_view,
67-
self.test_segment)
65+
self.test_view)
6866

6967
def test_with_allowed_types(self):
7068
objects = [self.test_signal] + self.test_spiketrains

0 commit comments

Comments
 (0)